Skip to content

[REF] web_company_color: Update fetching scss_template #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SirPyTech wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[REF] web_company_color: Update fetching scss_template #3426

SirPyTech wants to merge 1 commit into from
+3 −2

Conversation

@SirPyTech
Copy link

@SirPyTech SirPyTech commented Jan 30, 2026

Using a function to fetch SCSS_TEMPLATE to allow easier override from other modules.

Cherry-picked from #3185.

@anusriNPS @SirPyTech
[REF] web_company_color: Update fetching scss_template
b2e3565 
   Using a function to fetch SCSS_TEMPLATE
flotho
flotho reviewed Jan 30, 2026
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review LGTM

@SirPyTech
Copy link
Author

SirPyTech commented Jan 30, 2026

Thanks @flotho and @leemannd for having a look!

@flotho please click on "Approve" if these changes look good to you, so the review counts as an approval in Github Reviewers summary image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@flotho flotho flotho approved these changes

@leemannd leemannd leemannd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SirPyTech @flotho @leemannd @OCA-git-bot @anusriNPS