Fix issue with class-label webhook #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current issue with the assign-class-label webhook is that if the webhook pod goes down and the deployment tries to spin it back up, it fails. This is because the MutatingWebhookConfiguration is trying to call the webhook on the webhook pod, but there is no webhook pod so it fails to create. This commit makes it so that the MutatingWebhookConfiguration does not call the webhook on the webhook pod, that way if the pod goes down and tries to spin back up it is able to without failing because there is no webhook pod. This commit also changes replicas for the webhook pod to 2. Also adds the secret.yaml to the kustomization.yaml file. Signed-off-by: Isaiah Stapleton <[email protected]>
memalhot
approved these changes
Jul 10, 2025
dystewart
approved these changes
Jul 10, 2025
DanNiESh
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current issue with the assign-class-label webhook is that if the webhook pod goes down and the deployment tries to spin it back up, it fails. This is because the MutatingWebhookConfiguration is trying to call the webhook on the webhook pod, but there is no webhook pod so it fails to create. This commit
makes it so that the MutatingWebhookConfiguration does not call the webhook on the webhook pod, that way if the pod goes down and tries to spin back up it is able to without failing.
This commit also changes replicas for the webhook pod to 2. Also adds the secret.yaml to the kustomization.yaml file.