Skip to content

Avoid using drom at minimal version by default + Update version#14

Open
Ninjapouet wants to merge 2 commits intoOCamlPro:nextfrom
Ninjapouet:update_version
Open

Avoid using drom at minimal version by default + Update version#14
Ninjapouet wants to merge 2 commits intoOCamlPro:nextfrom
Ninjapouet:update_version

Conversation

@Ninjapouet
Copy link

No description provided.

@@ -1,5 +1,5 @@
[project]
drom-version = "0.1.0"
# drom-version = "0.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a doubt, does it mean that the drom-version is not specified, or the version of drom is added as drom-version in the drom.toml file ? I think it is important that a value is always written, but I don't really care which version is chosen by default.

Actually, there is also the idea that there is a phase of creation of the project, during which these files are modified by the project creator (and all other files are updated), while when the creation phase is over, only a minimal set of files are updated. We could decide that ending the creation phase requires setting the drom-version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the corresponding drom, if no drom-version is given, drom will use its current version.

As for the creation phase, I dont' know... Personally, I always have to change drom stuff during a project lifetime so I don't really see a "creation phase". drom should simplifies the programmer's life, not complicate it with more (possibly non standard) processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments