Skip to content

Conversation

@S41d
Copy link
Collaborator

@S41d S41d commented Jan 15, 2026

closes #7

@redianthus
Copy link
Member

@S41d, I had a quick look at the diff of the whitelist file and it seems the way it is sorted is a little bit weird, see for instance : https://github.com/OCamlPro/symbocalypse/pull/26/changes#diff-9e2f738738dc49139d1c2391401e34b3db5aa499940fc3d8b54bd01f4816b7b1R90-R93

Do you think you could fix it? It should be better because :

  • it minimizes the diff and makes it easier for me to see which file have been added and try to understand what they are;
  • the order in which they appear is the order in which they'll run, and it makes many things easier when they are sorted (for instance navigating through benchs results)

@S41d S41d force-pushed the update-testcomp branch 2 times, most recently from 8bcccec to 20a4eea Compare January 16, 2026 10:07
@redianthus
Copy link
Member

Thanks!

@redianthus redianthus merged commit f293c66 into OCamlPro:main Jan 21, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update test-comp submodules so that we get latest benchmarks

2 participants