Merged
Conversation
* improve code efficiency of two functions of class AggregatedDataset() : init() and mapSplitsToDataset() * allows to record dataframe in parquet format in addition to csv format * add possibility to divide between test and train absed on subregion (c-region) as well as the possibility to have randomness and different sampling from sampling to sampling in set_train_test_split(). assign_train_test_indices(self,train_indices, test_indices, test_size) is defined to update dataloader with the values of the selected test/train divisions after 10 sampling based on subregion. * adapation of dataset.py to choose output format of _get_output_filename() between csv and parquet * Alban's feedback on PR : mapSplitsToDataset() and init() more efficient for large dataset, output format to csv and parquet * Alban's feedback on PR : split on subregion added, modification of _create_group_kfold_splits() to cross-validate on subregion * Add function to plot test and train dataset (SMB versus elevation * Adapation of dataloader to asnwer review of #158 and new plot functions * to asnwer review of #158 * correct __init__ for mbm plot * preprocess WGMS data to be used by MBM #169 --------- Co-authored-by: Alban Gossard <alban.paul.gossard@gmail.com>
albangossard
added
the
new mass balance data
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #177 +/- ##
==========================================
+ Coverage 43.08% 43.86% +0.77%
==========================================
Files 61 62 +1
Lines 4804 4854 +50
==========================================
+ Hits 2070 2129 +59
+ Misses 2734 2725 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the preprocessing of WGMS data added by @JoachimPiret in #172 + some fixes and unit tests