Skip to content

Use the configured HandleNullPropagationOption #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielBertocci wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use the configured HandleNullPropagationOption #1538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Microsoft.AspNetCore.OData/Query/Expressions/SelectExpandBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,12 +1227,10 @@ private Expression AddOrderByQueryForSource(QueryBinderContext context, Expressi
return source;
}

private QueryBinderContext CreateSubContext(QueryBinderContext context, ComputeClause computeClause, Type clrElementType,
HandleNullPropagationOption option = HandleNullPropagationOption.True)
private QueryBinderContext CreateSubContext(QueryBinderContext context, ComputeClause computeClause, Type clrElementType)
Copy link
Member

@WanjohiSammy WanjohiSammy Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not pass the HandleNullPropagation in the caller. For example:

  • In SelectExpandBinder, you can pass as follows: 
    // rest of code ..
QueryBinderContext subContext = CreateSubContext(context, computeClause, clrElementType, settings.HandleNullPropagation);
// rest of code ...

Copy link
Author

@DanielBertocci DanielBertocci Nov 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WanjohiSammy. The reason why I didn't pass HandleNullPropagation in the caller is because CreateSubContext originally clones the settings:

ODataQuerySettings newSettings = new ODataQuerySettings();
newSettings.CopyFrom(context.QuerySettings);

The CopyFrom method does copy the HandleNullPropagation value:

internal void CopyFrom(ODataQuerySettings settings)
{
    // ...
    HandleNullPropagation = settings.HandleNullPropagation;
    // ...
}

I kept this approach because the original code also cloned context.QuerySettings, and I wanted to preserve that behavior unless there's a specific reason to move to the overload that takes HandleNullPropagation directly. If using the explicit overload is preferred for clarity, I can switch to that as well.

{
ODataQuerySettings newSettings = new ODataQuerySettings();
newSettings.CopyFrom(context.QuerySettings);
newSettings.HandleNullPropagation = option;
QueryBinderContext binderContext = new QueryBinderContext(context, newSettings, clrElementType);
if (computeClause != null)
{
Expand Down