Conversation
|
Thank you very much for your contribution @ablack3 ! Could you please provide more details in the PR description about the changes and their intent (for example, regarding quantile, safe_quantile, etc., in Also, could you please check the develop branch for the latest changes? Some of the functions you updated have recently been moved to a new file, We are currently working on more detailed contribution guidelines and will share them soon. |
# Conflicts: # R/main.R
| getConDF <- function(connectionDetails, json, name, cdmSchema, writeSchema){ | ||
|
|
||
| connection <- DatabaseConnector::connect(connectionDetails = connectionDetails) | ||
| on.exit(DatabaseConnector::disconnect(connection), add = TRUE) |
There was a problem hiding this comment.
Here I think it's good practice to register disconnect right after connecting to make sure connections are not leaked.
| Suggests: | ||
| testthat (>= 3.0.0), | ||
| DBI, | ||
| duckdb, |
There was a problem hiding this comment.
duckdb was taking a long time to compile in the docker image so I removed it. I'm not sure if it is needed for the package though. If it is let me know and I'll add it to the docker image.
| @@ -0,0 +1,98 @@ | |||
| # ARTEMIS Docker Image | |||
There was a problem hiding this comment.
This is just a simple readme on how to use the docker image and importantly how to save and load it onto a machine that is not connected to the internet (offline execution situation).
| @@ -0,0 +1,99 @@ | |||
| FROM rocker/rstudio:4.4.3 | |||
There was a problem hiding this comment.
I had some issues with the latest rocker rstudio image but 4.4.3 seemed to work well. this dockerfile should build the Artemis docker image with all necessary dependencies. I did minimal testing, just to make sure the package was installed and could be loaded.
| @@ -0,0 +1,70 @@ | |||
| name: build-rstudio-image-arm64 | |||
There was a problem hiding this comment.
I wanted to build both arm64 and amd64 images to support both architectures. I tried using buildx but that took an extremely long time to build on github, possibly due to compilation under emulation. Anyway having two workflow files seemed like the best solution and built the images in parallel on github actions in a reasonable amount of time. These workflows are triggered manually which could be customized to whatever works best for you but they do take a long time to run.
There was a problem hiding this comment.
We might also want to build an image for windows too. I think windows can run linux images if WSL is enabled though.
|
|
||
| jobs: | ||
| build-push-amd64: | ||
| runs-on: ubuntu-latest |
|
|
||
| jobs: | ||
| build-push-arm64: | ||
| runs-on: ubuntu-24.04-arm |
There was a problem hiding this comment.
run on an arm based linux machine
|
Hi @strahinjastevanovic, Happy to contribute! I made this PR specific to the docker image builders. I tested them on my personal github and added some comments in the PR. |
2 participants
#61
Github Docker build seems to work.
https://github.com/ablack3/ARTEMIS/actions
https://hub.docker.com/repository/docker/ablack3/artemis-rstudio/general