First draft of query updates to support CM v6#13
Merged
Conversation
Collaborator
Author
|
@jreps per our discussion, I've made modifications to this branch in an attempt to preserve backwards compatibly between CohortMethod v5 and v6. To that end, here is what has changed:
I'm still testing this out but wanted to summarize this here for others that may be following along with this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13 +/- ##
===========================================
- Coverage 92.54% 92.29% -0.26%
===========================================
Files 13 13
Lines 5244 5085 -159
===========================================
- Hits 4853 4693 -160
- Misses 391 392 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates queries based on upcoming changes for CohortMethod v6. One thing that needs discussion with @schuemie is the addition of the nesting cohort for indications - that is not currently supported by the queries in this package so we probably need to add those to the shiny modules and these reporting queries.
Here is some code I used to test the query changes on this branch: