Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the web UI from core/web to plugins/web, restructuring it as a plugin. The changes enable the web application to be served through the plugin system at /plugins/trex/web/ instead of directly at the base path.
Changes:
- Relocated the entire web application from
core/webtoplugins/web - Introduced
VITE_UI_BASE_PATHenvironment variable to distinguish between API base path and UI base path - Implemented SPA fallback routing in the plugin system for proper client-side routing
- Updated the root redirect to point to the new plugin-based web UI location
Reviewed changes
Copilot reviewed 10 out of 86 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
plugins/web/vite.config.ts |
Added uiBasePath variable and proxy config for /plugins endpoint |
plugins/web/package.json |
Updated package metadata with trex UI plugin configuration |
plugins/web/src/App.tsx |
Changed BASE_PATH to UI_BASE_PATH for router basename |
plugins/web/src/lib/config.ts |
Added UI_BASE_PATH export using import.meta.env.BASE_URL |
core/server/plugin/ui.ts |
Added SPA fallback middleware for plugin routes |
core/server/index.ts |
Removed core web static serving, updated root redirect |
docker-compose.yml |
Added volume mount for built web plugin |
| Various new files | Added comprehensive admin UI pages, components, and markdown rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.