Skip to content

fix pl#131

Merged
p-hoffmann merged 3 commits intodevelopfrom
p-hoffmann/fixpl
Mar 4, 2026
Merged

fix pl#131
p-hoffmann merged 3 commits intodevelopfrom
p-hoffmann/fixpl

Conversation

@p-hoffmann
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 4, 2026 05:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a dedicated DuckDB connection pool for streaming query execution and wires it into both the loadable extension runtime and the edge-runtime trex_core extension.

Changes:

  • Initialize a new “streaming pool” alongside the existing query executor initialization.
  • Update op_execute_query_stream to acquire/release a pooled connection instead of cloning from the shared active connection.
  • Update the edge-runtime lockfile to reflect the current dependency graph.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.

File Description
plugins/runtime/src/lib.rs Initializes the streaming pool when storing the shared connection for the loadable extension runtime.
plugins/runtime/edge-runtime/ext/trex/lib.rs Initializes the streaming pool in TREX_DB and switches streaming queries to use pooled connections.
plugins/runtime/edge-runtime/ext/trex/connection.rs Adds StreamingPool implementation plus init/get helpers backed by OnceLock.
plugins/runtime/edge-runtime/Cargo.lock Dependency resolution updates for the edge-runtime workspace.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p-hoffmann p-hoffmann merged commit 4b26182 into develop Mar 4, 2026
35 of 37 checks passed
@p-hoffmann p-hoffmann deleted the p-hoffmann/fixpl branch March 4, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants