Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated DuckDB connection pool for streaming query execution and wires it into both the loadable extension runtime and the edge-runtime trex_core extension.
Changes:
- Initialize a new “streaming pool” alongside the existing query executor initialization.
- Update
op_execute_query_streamto acquire/release a pooled connection instead of cloning from the shared active connection. - Update the edge-runtime lockfile to reflect the current dependency graph.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
plugins/runtime/src/lib.rs |
Initializes the streaming pool when storing the shared connection for the loadable extension runtime. |
plugins/runtime/edge-runtime/ext/trex/lib.rs |
Initializes the streaming pool in TREX_DB and switches streaming queries to use pooled connections. |
plugins/runtime/edge-runtime/ext/trex/connection.rs |
Adds StreamingPool implementation plus init/get helpers backed by OnceLock. |
plugins/runtime/edge-runtime/Cargo.lock |
Dependency resolution updates for the edge-runtime workspace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.