Handle connection errors during event writes#48
Open
teancom wants to merge 1 commit intoOHF-Voice:mainfrom
Open
Handle connection errors during event writes#48teancom wants to merge 1 commit intoOHF-Voice:mainfrom
teancom wants to merge 1 commit intoOHF-Voice:mainfrom
Conversation
Add exception handling for ConnectionResetError, ConnectionError, and BrokenPipeError in both AsyncEventHandler.run() and async_write_event() to prevent "Task exception was never retrieved" errors when clients disconnect. Client disconnects are normal and shouldn't be treated as exceptional conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see this error pretty much every time I restart the openWakeWord app in Home Assistant:
Did a bit of digging, tracked it down to this. Commit message follows.
Add exception handling for ConnectionResetError, ConnectionError, and BrokenPipeError in both AsyncEventHandler.run() and async_write_event() to prevent "Task exception was never retrieved" errors when clients disconnect. Client disconnects are normal and shouldn't be treated as exceptional conditions.