Skip to content

Conversation

@GhadeerAlbattarni
Copy link
Contributor

@GhadeerAlbattarni GhadeerAlbattarni commented Feb 10, 2026

Context

Fixes #5702

This PR fixes long series names overlapping in DICOM Tag Browser series selector.

Changes && Results

Added SelectValue component with label content to enable proper text display

Screenshot 2026-02-10 at 6 27 25 PM

Testing

  1. Open a study that has long series name (e.g. StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.5099.8010.217836670708542506360829799868 )
  2. Open the Dicom tag bowser for the series that has long name
  3. Verify series names are truncated with ellipsis (...) in the select field

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: macOS 10.15.4
  • Node version: v22.12.0
  • Browser: Chrome 83.0.4103.116

Greptile Overview

Greptile Summary

Fixed long series names overlapping in the DICOM Tag Browser select field by wrapping the display content in a SelectValue component. The SelectTrigger component has [&>span]:truncate styling which applies truncation to child spans, and SelectValue (which is SelectPrimitive.Value from @radix-ui/react-select) renders as a span element, enabling proper ellipsis truncation for text overflow.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is minimal (only 8 lines modified), follows the correct pattern documented in the codebase's own showcase examples, and properly uses the UI library's components. The fix leverages existing CSS truncation styling already present in SelectTrigger, making it a clean and idiomatic solution
  • No files require special attention

Important Files Changed

Filename Overview
extensions/default/src/DicomTagBrowser/DicomTagBrowser.tsx Added SelectValue wrapper to enable proper text truncation for long series names in the select field, fixing the overlap issue

(5/5) You can turn off certain types of comments like style here!

… select

  Used SelectValue to properly display and truncate long series names in the DICOM Tag Browser.
@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit adaab6a
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/698d2c124b69a100080fbd04

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Long series name overlaps in DICOM Tag Browser

1 participant