fix(dicom-tag-browser): Prevent long series names from overlapping #5809
+62
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #5702
This PR fixes long series names overlapping in DICOM Tag Browser series selector.
Changes && Results
Added
SelectValuecomponent with label content to enable proper text displayTesting
...) in the select fieldChecklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
Greptile Overview
Greptile Summary
Fixed long series names overlapping in the DICOM Tag Browser select field by wrapping the display content in a
SelectValuecomponent. TheSelectTriggercomponent has[&>span]:truncatestyling which applies truncation to child spans, andSelectValue(which isSelectPrimitive.Valuefrom@radix-ui/react-select) renders as a span element, enabling proper ellipsis truncation for text overflow.Confidence Score: 5/5
SelectTrigger, making it a clean and idiomatic solutionImportant Files Changed
SelectValuewrapper to enable proper text truncation for long series names in the select field, fixing the overlap issue(5/5) You can turn off certain types of comments like style here!