Skip to content

ci: add qa-simulation to runs - v1#2986

Closed
jufajardini wants to merge 1 commit intoOISF:masterfrom
jufajardini:sv-7885-qa-in-ci/v1
Closed

ci: add qa-simulation to runs - v1#2986
jufajardini wants to merge 1 commit intoOISF:masterfrom
jufajardini:sv-7885-qa-in-ci/v1

Conversation

@jufajardini
Copy link
Copy Markdown
Contributor

@jufajardini jufajardini commented Mar 24, 2026

Related to
Task #7885

Ticket

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/

Related to https://redmine.openinfosecfoundation.org/issues/7885 -- in the sense that we should have qa-simulation enabled...

Related to
Task #7885
Copy link
Copy Markdown
Collaborator

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to enable on the 2 out of 3

I wonder if SV CI should run all the tests, meaning one of the builds should disable ja3...

@jufajardini
Copy link
Copy Markdown
Contributor Author

Good to enable on the 2 out of 3

I wonder if SV CI should run all the tests, meaning one of the builds should disable ja3...

Like we have for Suri CI?

@catenacyber
Copy link
Copy Markdown
Collaborator

Good to enable on the 2 out of 3
I wonder if SV CI should run all the tests, meaning one of the builds should disable ja3...

Like we have for Suri CI?

I do not think we have that for suri CI : "that" being sure that "CI should run all the tests"

@jufajardini
Copy link
Copy Markdown
Contributor Author

jufajardini commented Mar 26, 2026

Good to enable on the 2 out of 3
I wonder if SV CI should run all the tests, meaning one of the builds should disable ja3...

Like we have for Suri CI?

I do not think we have that for suri CI : "that" being sure that "CI should run all the tests"

Ah, I meant the Suri build that has ja3 and ja4 disabled :P (Fedora (non-root, debug, clang, asan, wshadow, rust-strict, no-ja)

@catenacyber
Copy link
Copy Markdown
Collaborator

Wondering if I should create a ticket about "CI should make sure it runs all the SV tests"

@jasonish
Copy link
Copy Markdown
Member

Wondering if I should create a ticket about "CI should make sure it runs all the SV tests"

Would this require some cross-branch checking? For example, you might have to run main, 8.0.x and 7.0.x to really see? And stash the reports somewhere, and correlate after?

@catenacyber
Copy link
Copy Markdown
Collaborator

Wondering if I should create a ticket about "CI should make sure it runs all the SV tests"

Would this require some cross-branch checking?

I think we can manage to have something for main branch only, but it requires multiple Suricata builds (at least one with and one without ja3)

@jufajardini
Copy link
Copy Markdown
Contributor Author

Wondering if I should create a ticket about "CI should make sure it runs all the SV tests"

Would this require some cross-branch checking?

I think we can manage to have something for main branch only, but it requires multiple Suricata builds (at least one with and one without ja3)

a new ticket seems appropriate, I think. I was trying to see if I could do this and it took me longer than expected.

  • ja with
  • ja without
  • geoip
  • liblz4

Were the ones that seemed to be "missing".

I had a hard time finding the package for liblz4 for my Ubuntu 24.04 install, for some reason (didn't manage to, so far).

@jufajardini
Copy link
Copy Markdown
Contributor Author

Followed by: #2994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests pass These new tests should pass

Development

Successfully merging this pull request may close these issues.

4 participants