Closed
Conversation
Will help to use generic DetectEngineInspectBufferGeneric
reuse generic DetectEngineInspectBufferGeneric
catenacyber
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
Closed
Contributor
Author
|
This comes on top of approved #14711 |
catenacyber
commented
Jan 29, 2026
src/detect-engine-prefilter.c
Outdated
| if (t->sig_list == app_state_list_id) { | ||
| SCLogDebug("engine %s for state list", t->engine_name); | ||
| engine_progress = -1; | ||
| engine_progress = UINT8_MAX; |
Contributor
Author
There was a problem hiding this comment.
Is this really used ?..
|
ERROR: ERROR: QA failed on SURI_TLPR1_alerts_cmp. Pipeline = 29339 |
instead of a single progress. Will help for keywords such as http.header which can act on headers and trailers progress Tx engines are inspected between min_progress and max_progress So, we do not give up and says a signature does not match when it will match on later max_progress And we can match as early as possible, especially in IPS mode.
Function to register a app engine with a min and max progress
as it registers the app engine up to the trailers progress Ticket: 8256
catenacyber
force-pushed
the
detect-http-trailers-8256-v1
branch
from
cdbfe5e to
c533d34
Compare
and make scan-build happy
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14717 +/- ##
=======================================
Coverage 82.14% 82.15%
=======================================
Files 1007 1007
Lines 263194 263192 -2
=======================================
+ Hits 216210 216221 +11
+ Misses 46984 46971 -13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Next in #14724 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8256
Describe changes:
To do so :
DetectEngineAppInspectionEngineDetectAppLayerInspectEngineRegisterMaxfunction to register an app engine with a min_progress < max_progressSV_BRANCH=OISF/suricata-verify#2894