Closed
Conversation
|
Information: QA ran without warnings. Pipeline = 30012 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14955 +/- ##
==========================================
- Coverage 82.60% 82.58% -0.03%
==========================================
Files 990 992 +2
Lines 271506 271659 +153
==========================================
+ Hits 224290 224355 +65
- Misses 47216 47304 +88
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 30026 |
victorjulien
force-pushed
the
fw-updates/v4
branch
from
d171405 to
913666d
Compare
|
Information: QA ran without warnings. Pipeline = 30034 |
Allows for quickly checking if sig operates on frames during parsing.
Make `Signature::proto` an optional member, meaning that if it is NULL we can skip the check. This can be done for `alert ip`, as no check is needed, and for `alert tcp` and `alert udp` as having a rule in a sgh for those means that the protocol matches. Some exceptions are rules that require: - ipv4/ipv6 specific matching - frames, due to sharing prefilter between tcp and udp - ip-only rules, due to those not being per sgh
Support `alert ether` for matching all ethernet packets. Add `alert arp` for matching ARP packets. Ticket: OISF#8313.
Sticky buffer to inspect the ethernet header.
Example rule:
alert ether any any -> any any ( \
eth.hdr; content:"|08 06|"; offset:12; depth:2; \
sid:1;)
Ticket: OISF#8327.
To indicate it's not just like `alert ip`.
`alert pkthdr` was initially just an alias for `alert ip`, as that was really just a way of stating that "any" should be matched. However with the Ethernet matching in place, it no long makes sense to treat `alert ip` as "any". Since `pkthdr` is used to match on decoder events, also for packets that completely failed to parse, it should no longer be treated as `alert ip` but rather as it's own distinct logic.
victorjulien
force-pushed
the
fw-updates/v4
branch
from
913666d to
5d5d9be
Compare
|
Information: QA ran without warnings. Pipeline = 30102 |
Contributor
|
Why is this PR a draft ? |
catenacyber
reviewed
Mar 12, 2026
catenacyber
reviewed
Mar 12, 2026
catenacyber
reviewed
Mar 12, 2026
catenacyber
reviewed
Mar 12, 2026
catenacyber
reviewed
Mar 12, 2026
Contributor
|
Not sure I get the intention of |
catenacyber
reviewed
Mar 12, 2026
catenacyber
reviewed
Mar 12, 2026
catenacyber
reviewed
Mar 12, 2026
Contributor
My 2 cents : short is good |
Closed
Member
Author
|
Replaced by #15029. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft to introduce a way to accept
arppackets in fw bridge mode.SV_BRANCH=OISF/suricata-verify#2953
Some notable things:
alert ether .... Not sure about the name, could also beethorethernet?alert pkthdrto just decoder event rules. Previously it was just an alias foralert ip.