Backport8 8378 v1 dcerpc ctxids#15106
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #15106 +/- ##
==============================================
+ Coverage 83.59% 83.61% +0.02%
==============================================
Files 1011 1011
Lines 266822 266846 +24
==============================================
+ Hits 223048 223130 +82
+ Misses 43774 43716 -58
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
I feel like not doing rustfmt on stable branches leaves room for small mistakes that may go unnoticed in the diff but well it's not really a major change. Perhaps it should be considered. 🤷🏽♀️ |
I was denied the rustfmt back port in a previous PR Here we also get unclean cherry-pick because of we did not backport ed1bd86 |
|
Information: QA ran without warnings. Pipeline = 30556 |
Backports should be limited as much as possible to relevant changes. Clean up commits, reformatting, etc is hard to review, so they are generally not accepted. |
|
Merged in #15132, thanks! |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8380
Describe changes:
SV_BRANCH=OISF/suricata-verify#2990