Skip to content

Backport8 8378 v1 dcerpc ctxids#15106

Merged
victorjulien merged 2 commits intoOISF:main-8.0.xfrom
catenacyber:backport8-8378-v1
Mar 31, 2026
Merged

Backport8 8378 v1 dcerpc ctxids#15106
victorjulien merged 2 commits intoOISF:main-8.0.xfrom
catenacyber:backport8-8378-v1

Conversation

@catenacyber
Copy link
Copy Markdown
Contributor

So that we can log and detect on interface uuids, even if
AlterContext packets change one of the contexts, but other contexts
are still used after it in request/responses

Ticket: 8378
(cherry picked from commit 05a11e2)
Not all the state ones

Ticket: 8378
(cherry picked from commit 34ed895)
@catenacyber catenacyber requested a review from jasonish as a code owner March 26, 2026 07:55
@catenacyber catenacyber changed the title Backport8 8378 v1 Backport8 8378 v1 dcerpc ctxids Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 99.01961% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.61%. Comparing base (a4aa865) to head (831be60).
⚠️ Report is 2 commits behind head on main-8.0.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-8.0.x   #15106      +/-   ##
==============================================
+ Coverage       83.59%   83.61%   +0.02%     
==============================================
  Files            1011     1011              
  Lines          266822   266846      +24     
==============================================
+ Hits           223048   223130      +82     
+ Misses          43774    43716      -58     
Flag Coverage Δ
fuzzcorpus 64.01% <66.12%> (+0.02%) ⬆️
livemode 18.76% <0.00%> (-0.06%) ⬇️
pcap 44.64% <90.32%> (+0.04%) ⬆️
suricata-verify 64.88% <98.38%> (+0.03%) ⬆️
unittests 58.83% <57.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@inashivb
Copy link
Copy Markdown
Member

I feel like not doing rustfmt on stable branches leaves room for small mistakes that may go unnoticed in the diff but well it's not really a major change. Perhaps it should be considered. 🤷🏽‍♀️

Copy link
Copy Markdown
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@catenacyber
Copy link
Copy Markdown
Contributor Author

I feel like not doing rustfmt on stable branches leaves room for small mistakes that may go unnoticed in the diff but well it's not really a major change. Perhaps it should be considered. 🤷🏽‍♀️

I was denied the rustfmt back port in a previous PR

Here we also get unclean cherry-pick because of we did not backport ed1bd86

@suricata-qa
Copy link
Copy Markdown

Information: QA ran without warnings.

Pipeline = 30556

@victorjulien victorjulien added this to the 8.0 milestone Mar 27, 2026
@victorjulien
Copy link
Copy Markdown
Member

I feel like not doing rustfmt on stable branches leaves room for small mistakes that may go unnoticed in the diff but well it's not really a major change. Perhaps it should be considered. 🤷🏽‍♀️

Backports should be limited as much as possible to relevant changes. Clean up commits, reformatting, etc is hard to review, so they are generally not accepted.

@victorjulien victorjulien merged commit 831be60 into OISF:main-8.0.x Mar 31, 2026
116 checks passed
@victorjulien
Copy link
Copy Markdown
Member

Merged in #15132, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants