log-cf-common: let mktime determine proper tz - v1#15131
Closed
jufajardini wants to merge 1 commit intoOISF:main-8.0.xfrom
Closed
log-cf-common: let mktime determine proper tz - v1#15131jufajardini wants to merge 1 commit intoOISF:main-8.0.xfrom
jufajardini wants to merge 1 commit intoOISF:main-8.0.xfrom
Conversation
In some timezones, LogCustomFormatTest01 was failing as we were specifying the wrong setting for is_dst. Instead set it to -1 so mktime can make the decision based on the environment. Appears to fix this test for "Brazil/East" in the summer. Add GitHub CI tests to test this specific test with a few different timezones. (cherry picked from commit 468a13e)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #15131 +/- ##
==============================================
- Coverage 83.59% 83.58% -0.01%
==============================================
Files 1011 1011
Lines 266822 266822
==============================================
- Hits 223048 223023 -25
- Misses 43774 43799 +25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 30730 |
jasonish
approved these changes
Mar 31, 2026
victorjulien
approved these changes
Mar 31, 2026
Member
|
Merged in #15139, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some timezones, LogCustomFormatTest01 was failing as we were specifying the wrong setting for is_dst. Instead set it to -1 so mktime can make the decision based on the environment. Appears to fix this test for "Brazil/East" in the summer.
Add GitHub CI tests to test this specific test with a few different timezones.
(cherry picked from commit 468a13e)
Changes: