Skip to content

Backport8 8410 8413 v1 (http2, websocket)#15137

Closed
catenacyber wants to merge 2 commits intoOISF:main-8.0.xfrom
catenacyber:backport8-8410-8413-v1
Closed

Backport8 8410 8413 v1 (http2, websocket)#15137
catenacyber wants to merge 2 commits intoOISF:main-8.0.xfrom
catenacyber:backport8-8410-8413-v1

Conversation

@catenacyber
Copy link
Copy Markdown
Contributor

Ticket: 8410

Do not set only request_frame_size whatever the direction

(cherry picked from commit 7b0528d)
Ticket: 8413

RFC 6455 Section 5.4 states

Control frames (see Section 5.5) MAY be injected in the middle of
a fragmented message.

Control frames are identified by opcodes where the most significant
bit of the opcode is 1.

(cherry picked from commit 2fa1005)
@catenacyber catenacyber requested a review from jasonish as a code owner March 31, 2026 19:31
@catenacyber catenacyber changed the title Backport8 8410 8413 v1 Backport8 8410 8413 v1 (http2, websocket) Mar 31, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.60%. Comparing base (831be60) to head (2028f1e).
⚠️ Report is 5 commits behind head on main-8.0.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-8.0.x   #15137      +/-   ##
==============================================
- Coverage       83.61%   83.60%   -0.02%     
==============================================
  Files            1011     1011              
  Lines          266846   266848       +2     
==============================================
- Hits           223130   223090      -40     
- Misses          43716    43758      +42     
Flag Coverage Δ
fuzzcorpus 64.01% <100.00%> (-0.01%) ⬇️
livemode 18.72% <0.00%> (-0.04%) ⬇️
pcap 44.61% <83.33%> (-0.03%) ⬇️
suricata-verify 64.86% <83.33%> (-0.02%) ⬇️
unittests 58.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link
Copy Markdown

Information: QA ran without warnings.

Pipeline = 30761

@victorjulien
Copy link
Copy Markdown
Member

Merged in #15139, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants