fix: editor.commit should respect squash and title #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stee-re
force-pushed
the
fix_editor-commit-should-respect-squash-and-title
branch
from
f0b2744 to
8d64fb5
Compare
ca-d
approved these changes
Aug 28, 2025
Contributor
There was a problem hiding this comment.
LGTM, but I would have an easier time understanding the commit message if it read:
fix: handleEditEventV2 should respect squash and title
since editor.commit already does so — as far as I understand — and we’re using that very fact in order to improve our event handler here.
stee-re
force-pushed
the
fix_editor-commit-should-respect-squash-and-title
branch
from
8d64fb5 to
b3a99c0
Compare
Contributor
Author
|
Good catch - corrected the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.