Skip to content

Conversation

@stee-re
Copy link
Contributor

@stee-re stee-re commented Jan 16, 2026

Shell was making hard references to colour variables which were not --oscd theme colours, thus preventing distros from being able to customize them. This PR aims to correct that.

Whats changed:

  • Shell (and relatives) reference only oscd-* variables
  • Shell now sets all the --oscd-* variables based on their --oscd-theme_* counterparts, falling back to sensible defaults.
  • Shell sets all the --md-* and --mdc-* defaults based on --oscd-* variables.
  • Setting of theme variables is done within the scope of the demo (for reference)

@stee-re stee-re requested a review from ca-d January 16, 2026 12:46
@stee-re stee-re force-pushed the fix_correct-theming-references branch from ddef03a to 7a8e834 Compare January 19, 2026 08:43
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stee-re stee-re merged commit be3f7c1 into OMICRONEnergyOSS:main Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants