-
Notifications
You must be signed in to change notification settings - Fork 3
Economist style ticks #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ultimately we want to allow users to switch between Economist-style and specific points (using getXAxisTicks) |
You mean in the config? @broadpeter |
|
OK added the option into the config, although I did an alternative where I just use getXAxisTicks to get an array to pass into |
nrennie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong opinions on economist style axes, but whatever is decided - can you also add it to the two line-chart-sm, line chart dropdown, and two line chart with ci-area when it's ready?
Should getXAxisTicks() in the line-chart template be moved into the helpers.js file?
See also #361
|
Ready for review |
|
@nrennie @broadpeter @sam-ctrl Ready to review and merge. Column charts all work, custom starting months work. Had to put the readme in the lib folder as I didn't know where else to put it. |
sam-ctrl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh slick, I had a test and it's really nice. Technically it all looks good to me. I will leave it to others (@broadpeter) to comment on style etc. but to my layman's eyes that all looks good too.

First attempt at customTimeAxis for economist style ticks