Merged
Conversation
jessjenkins
reviewed
Mar 9, 2026
9d71b2f to
2e7db61
Compare
jessjenkins
previously approved these changes
Mar 9, 2026
jessjenkins
reviewed
Mar 9, 2026
a2fb162 to
8a6bcc4
Compare
jessjenkins
previously approved these changes
Mar 9, 2026
jessjenkins
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This began as fixing a slack failure whereby it was sending multiple messages on a failure but has ended up as a larger refactor.
The meat of this is that now rather than managing a job "transition" on task success, we also do it on failure. Additionally, the store will now report back if a state transition has already been done to cut down on race condition / clashes.
Other minor fixes:
How to review
Check looks ok, makes sense, tests pass.
To optionally test, you can:
Who can review
Not me.