Skip to content

Fix/slack integration#67

Merged
lindenmckenzie merged 12 commits intomainfrom
fix/slack-integration
Mar 9, 2026
Merged

Fix/slack integration#67
lindenmckenzie merged 12 commits intomainfrom
fix/slack-integration

Conversation

@lindenmckenzie
Copy link
Contributor

@lindenmckenzie lindenmckenzie commented Mar 4, 2026

What

This began as fixing a slack failure whereby it was sending multiple messages on a failure but has ended up as a larger refactor.

The meat of this is that now rather than managing a job "transition" on task success, we also do it on failure. Additionally, the store will now report back if a state transition has already been done to cut down on race condition / clashes.

Other minor fixes:

  • hide slack api token from logs (not currently a security concern as it was not deployed)
  • failure messages to info channel now show a red line
  • consistent ordering of slack details
  • other minor tidy ups (log messages)
  • upgrade go to 1.26.1
  • refactor CI tests to not use setup

How to review

Check looks ok, makes sense, tests pass.

To optionally test, you can:

  • retrieve a slack token from https://api.slack.com/ for the migration service
  • set the slack variables in the migration service in dp-compose
  • run the test migration to see success
  • to see failure, I switched off the dp-upload-service and then ran the test migration

Who can review

Not me.

@lindenmckenzie lindenmckenzie requested a review from a team as a code owner March 4, 2026 14:56
@lindenmckenzie lindenmckenzie force-pushed the fix/slack-integration branch from 9d71b2f to 2e7db61 Compare March 9, 2026 14:48
jessjenkins
jessjenkins previously approved these changes Mar 9, 2026
@lindenmckenzie lindenmckenzie force-pushed the fix/slack-integration branch from a2fb162 to 8a6bcc4 Compare March 9, 2026 15:16
jessjenkins
jessjenkins previously approved these changes Mar 9, 2026
@lindenmckenzie lindenmckenzie merged commit 5397a1b into main Mar 9, 2026
10 checks passed
@lindenmckenzie lindenmckenzie deleted the fix/slack-integration branch March 9, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants