Merged
Conversation
go.mod
Outdated
| module github.com/ONSdigital/dis-redirect-proxy | ||
|
|
||
| go 1.25 | ||
| go 1.24.7 |
Contributor
There was a problem hiding this comment.
Never that sure on this - might be worth talking to Jess about whether we should be specifying patch version here or not.
Contributor
There was a problem hiding this comment.
I tried to clarify the go directive in the dependency upgrading standards. But basically this needs to be the minimum version of go needed to compile this code. It's probably safe to use the lowest minor version so 1.24.0 should be good enough. As long as the ci.yml is the same or higher we're good.
Oluwawunmi
force-pushed
the
feature/switch-vulncheck
branch
2 times, most recently
from
d9aa830 to
a84c8aa
Compare
Oluwawunmi
force-pushed
the
feature/switch-vulncheck
branch
from
a84c8aa to
b11ee72
Compare
lindenmckenzie
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switch to vulncheck
How to review
Check changes are ok.
Check tests pass.
Who can review
!me