Conversation
2641f26 to
4804743
Compare
2e34844 to
e303416
Compare
cookel2
left a comment
There was a problem hiding this comment.
The syntax looks good to me. But I haven't been very successful with trying to run the stack so far. Whether I use make up or make up-with-seed I always get these log messages in the migration service (despite having tried following all the prerequisites for the topics too): - failed as unexpected code from topic api: 404
- failed to get root topic from topic-api
- initial topic cache population failed - no topics were loaded
- failed to initialise topic cache
- running service failed: initial topic cache population failed - no topics were loaded
|
@cookel2 you may need to restart the |
cookel2
left a comment
There was a problem hiding this comment.
I've had another try and managed to get the stack running healthily with the topics seeded this time. However, I did have to refresh the migration service (as advised). But then when I tried running the first POST request to localhost:30100/v1/migration-jobs it gave me a 403 Forbidden error with this message: "data": {
"permission": "migrations:create"
},
"event": "permission not found in permissions bundle",
"namespace": "dis-migration-service",
e303416 to
1703e61
Compare
cookel2
left a comment
There was a problem hiding this comment.
A couple of comments on the readme. But also I get a "source ID is invalid" error, with a 400 code, when I try calling localhost:30100/v1/migration-jobs. I noticed that the source ID contains a repetition of the words "labourdisputes" in datasets/labourdisputeslabourdisputesannualestimates but when I tried removing the duplication it still gave me the same error.
ce20bd8 to
6f09708
Compare
v2/stacks/migration/README.md
Outdated
| 3a. If you don't want to run the stack with the databases seeded, you can use: | ||
|
|
||
| ```sh | ||
| make up |
There was a problem hiding this comment.
This make command and the other ones in this readme all have leading spaces that it would be useful to remove.
There was a problem hiding this comment.
Have reformatted a bunch of things.
cookel2
left a comment
There was a problem hiding this comment.
It works for me now, thanks
What
Added some quality of life changes for migration stack:
How to review
You can run the stack with the example dataset and try looking at:
/migration-jobs/{jobNumber}/eventsendpoint.reset collection requires changes to the
dis-migration-servicethat are currently on a branch: ONSdigital/dis-migration-service#64Who can review
Not me.