Skip to content

Feature/enhance migration#282

Merged
lindenmckenzie merged 10 commits intomainfrom
feature/enhance-migration
Mar 12, 2026
Merged

Feature/enhance migration#282
lindenmckenzie merged 10 commits intomainfrom
feature/enhance-migration

Conversation

@lindenmckenzie
Copy link
Contributor

@lindenmckenzie lindenmckenzie commented Feb 17, 2026

What

Added some quality of life changes for migration stack:

  • reset zebedee collections
  • add dis-design-system-go
  • enable audit logging
  • add slack integration variables
  • add permissions api to the dp-api-router manifest

How to review

You can run the stack with the example dataset and try looking at:

  • view the migrated dataset via the dp-frontend-dataset-controller
  • use the slack integration by getting the OAuth token from the migration service app in slack
  • check the audit logging happening in via the /migration-jobs/{jobNumber}/events endpoint.

reset collection requires changes to the dis-migration-service that are currently on a branch: ONSdigital/dis-migration-service#64

Who can review

Not me.

Base automatically changed from feature/permissions to main February 18, 2026 15:22
@lindenmckenzie lindenmckenzie force-pushed the feature/enhance-migration branch from 2e34844 to e303416 Compare February 24, 2026 14:37
Copy link
Contributor

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax looks good to me. But I haven't been very successful with trying to run the stack so far. Whether I use make up or make up-with-seed I always get these log messages in the migration service (despite having tried following all the prerequisites for the topics too): - failed as unexpected code from topic api: 404

  • failed to get root topic from topic-api
  • initial topic cache population failed - no topics were loaded
  • failed to initialise topic cache
  • running service failed: initial topic cache population failed - no topics were loaded

@lindenmckenzie
Copy link
Contributor Author

@cookel2 you may need to restart the dis-migration-service after the topic seeding script is run.

@cookel2 cookel2 self-requested a review March 6, 2026 20:42
Copy link
Contributor

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had another try and managed to get the stack running healthily with the topics seeded this time. However, I did have to refresh the migration service (as advised). But then when I tried running the first POST request to localhost:30100/v1/migration-jobs it gave me a 403 Forbidden error with this message: "data": {
"permission": "migrations:create"
},
"event": "permission not found in permissions bundle",
"namespace": "dis-migration-service",

@lindenmckenzie lindenmckenzie force-pushed the feature/enhance-migration branch from e303416 to 1703e61 Compare March 9, 2026 14:21
Copy link
Contributor

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments on the readme. But also I get a "source ID is invalid" error, with a 400 code, when I try calling localhost:30100/v1/migration-jobs. I noticed that the source ID contains a repetition of the words "labourdisputes" in datasets/labourdisputeslabourdisputesannualestimates but when I tried removing the duplication it still gave me the same error.

@lindenmckenzie lindenmckenzie force-pushed the feature/enhance-migration branch from ce20bd8 to 6f09708 Compare March 9, 2026 15:42
3a. If you don't want to run the stack with the databases seeded, you can use:

```sh
make up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make command and the other ones in this readme all have leading spaces that it would be useful to remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have reformatted a bunch of things.

@cookel2 cookel2 self-requested a review March 12, 2026 11:03
Copy link
Contributor

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me now, thanks

@lindenmckenzie lindenmckenzie merged commit 3d37e79 into main Mar 12, 2026
5 checks passed
@lindenmckenzie lindenmckenzie deleted the feature/enhance-migration branch March 12, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants