upgrade Shopify/sarama -> IBM/sarama (dp-kafka/v5)#101
Merged
jessjenkins merged 4 commits intomainfrom Jan 6, 2026
Merged
Conversation
cookel2
reviewed
Jan 2, 2026
Contributor
cookel2
left a comment
cookel2
left a comment
There was a problem hiding this comment.
just one very small comment
cookel2
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgraded version of sarama to support v3.8.0 of kafka connector. This also required the following…
health.go)v5due to aforementioned breaking changeHow to review
Mostly package name changes, check code makes sense and tests pass.
Who can review
Anyone but me