SAIL_302 update imports from "typing" package #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request submission
We were previously importing
Dict,List,Tuple,CallableandUnionfromtyping.All these are outdated so I have removed them:
dict,listandtupleare now natively supportedCallablenow needs to be imported fromcollections.abc(tried to find alternatives, don't think there are any)Unionshould be replaced by|I have made these changes in the code.
The tests pass, but in my set up the pipeline fails on "split on bool", which is another type/ outdated syntax issue.
I suppose developing in python 3.6 has been a disadvantage that's impacting us now.
Closes or fixes
Closes #
Code
Documentation
Any new code includes all the following forms of documentation:
Argsandreturnsfor all major functionsData
Testing
Peer Review Section
requirements.txtFinal approval (post-review)
The author has responded to my review and made changes to my satisfaction.
Review comments
Insert detailed comments here!
These might include, but not exclusively:
that it is likely to interact with?)
works correctly?)
Your suggestions should be tailored to the code that you are reviewing.
Be critical and clear, but not mean. Ask questions and set actions.