Sail_302 fix validation to return amended dataframes #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request submission
Updated
validate_data_with_schemafunction which now returns an amended dataframe.In the process I broke up the function to smaller ones so we no longer have to suppress a complexity error.
Also updated
combined_schemas_validate_full_dfwhich does a similar job- I reused the new validation functions and ensures it now returns an updated schema.New and updated tests added.
A few other minor updates were performed which mean the pipeline now runs with my installation.
I have tried to keep different tasks to different commits, so hopefully following those will be helpful in review.
NOTE: MERGE THESE FIRST:
Closes or fixes
Closes #
Code
Documentation
Any new code includes all the following forms of documentation:
Argsandreturnsfor all major functionsData
Testing
Peer Review Section
requirements.txtFinal approval (post-review)
The author has responded to my review and made changes to my satisfaction.
Review comments
Insert detailed comments here!
These might include, but not exclusively:
that it is likely to interact with?)
works correctly?)
Your suggestions should be tailored to the code that you are reviewing.
Be critical and clear, but not mean. Ask questions and set actions.