Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the workstation locking functionality by extracting duplicated platform-specific lock code into a new lock_workstation() function. It also adds proper Linux support with multiple screen locker fallbacks and extends CI testing to Ubuntu and macOS.
- Introduces a dedicated
lock_workstation()function to consolidate duplicated locking logic - Implements a fallback mechanism for Linux that tries multiple screen lockers (loginctl, xdg-screensaver, gnome-screensaver-command, dm-tool, xscreensaver-command)
- Expands CI/CD testing matrix to include ubuntu-latest and macos-latest alongside windows-latest
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/loctight.py | Refactored platform-specific lock logic into a reusable lock_workstation() function with Linux fallback support; replaced two duplicate lock code blocks with function calls |
| .github/workflows/tests.yml | Extended test matrix to run on Ubuntu and macOS in addition to Windows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.