Resolves OP-Engineering/link-preview-js#159 - Creates an onResponse c…#170
Merged
ospfranco merged 2 commits intoOP-Engineering:mainfrom May 26, 2025
Merged
Conversation
… overriding post-parse values
ospfranco
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
onResponseoption that is a callback function that allows the developer to modify the contents of the parsed response body, in the event there needs to be custom logic or sources for different properties. For example, say the targeted website does not provide opengraph description, the developer might want to instead have the description be the text contents of the first p tag. Additionally, an instance of the URL object has been exposed so the callback could contain site-by-site considerations.ILinkPreviewResponsefor the actual library response for type safety.Tests passed locally (Github CI tests might break due to bot detection)
This PR will resolve #159