WHATWG URL usage for URL resoltuon with React Native detection #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e native WHATWG URL API unless react-native is detected, then it uses the url library. Fixes OP-Engineering#172
ospfranco
reviewed
Nov 15, 2025
| // Check for React Native specific global objects | ||
| const hasNativeBridgeHook = | ||
| typeof global !== 'undefined' && | ||
| (typeof (global as any).nativeCallSyncHook === 'function' || |
Collaborator
There was a problem hiding this comment.
This looks outdated and might not be true under the new arch.
Collaborator
|
Sorry buddy, I'm not going to merge this until I absolutely have to. Not worth my time ask for more work when something is not broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the code to use WHATWG except in environments it detects as React-Native. This detection looks for global hooks that React-Native injections and ensures that it's an environment without a DOM. As long as at least one of these standard hooks are present and there is no DOM detected, the environment is determined to be react-native and the url library is used instead.
If React-Native is not detected, it will use the default, native WHATWG URL API instead. This will prevent deprecation warnings and potential security issues.
A new configuration boolean option was added called
forceLegacyUrlResolve. If there is ever such an edge case that the React Native isn't detected (e.g., if future implementations remove the current global hooks or suddenly start working with a window/document object), developers can setforceLegacyUrlResolveas true, which will bypass auto-detection and force the use of the external url library.This PR should resolve concerns of breaking compatibility with react-native and allows the nodejs environment to work with the library that's is best suited for it.
Fixes #172