-
-
Notifications
You must be signed in to change notification settings - Fork 79
Add execute sync raw endpoint #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute sync raw endpoint #312
Conversation
src/index.ts
Outdated
| executeRawSync: (query: string, params?: Scalar[]) => { | ||
| const sanitizedParams = sanitizeArrayBuffersInArray(params); | ||
| let res = sanitizedParams | ||
| ? db.executeSync(query, sanitizedParams as Scalar[]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look correct. If you take a look at the function above a executeRaw is a different native implementation than executeSync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right apologies - added the native call with a passing test in the latest commit.
|
Things seem to be broken on iOS only (which is weird), just FYI @joshua-journey-apps |
|
Found this write up. Looks like macos runner went through a migration to macos-15 on 4 August. There was a some breakage regarding the default Xcode version being set 16.0 while macos-latest having 16.4 minimum requirement for newer IOS simulators. A quick fix would be to pin the runner to There are other workarounds like adding the following step to all the ios runners in the steps:
- name: Select Xcode 16.4
run: sudo xcode-select -s '/Applications/Xcode_16.4.app/Contents/Developer'or steps:
- name: Update Xcode
run: xcodebuild -downloadPlatform iOS |
|
using xcode-select should work. That's what I did in another project. |
…e-raw-sync Add execute sync raw endpoint
Adds
executeRawSyncmethod for synchronous access to raw query results.The library has async raw methods (
executeRaw,executeRawAsync) but no sync equivalent. UsingexecuteSyncand accessingrawRowscreates unnecessary overhead from row mapping that gets discarded.Changes
executeRawSyncthat returnsrawRowsdirectly without column mapping