Merge latest master into release/1.5.375 #3004
Merged
+1,194
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generate ECC Certificates in Client Tests * Add more tests * reenable check of certificate * fix tests * Dont use random in test * fix unsupported certificate types * fix Hash algorithm for nistP384 curve on linux as the friendly name is ECDSA_P384 instead of nistP384 * use friendly name by default and add special case only for linux while taking care of nullability * disable special casing for finding correct certificates * fix tests on net 462 * update Certificate Identifier
…y Client AddMonitoredItems Method Call (#2984) * fix Sampling Group creating a new long running task for every Client Add MonitoredItems Method Call * reset also on shutdown * dispose shutdown event
… reaches MaxChannelCount - 1 (#2986) * Remove older channel if not used by session, when number of channels reaches MaxChannelCount - 1 * Corrected channelCount and renamings * Operate on snapshot * Snapshot the entire concurentdictionary
* Add tests to catch if NodeId.Null is modified in DEBUG, fix an issue where NodeId.Null was overwritten * add (C) * only enable immutable NodeId to catch issues * typos and comments
* Update SessionReconnectHandler.cs There is chance that m_session.DetachChannel can clear the member "Endpoint" info of the session, once that happened, there will be crash when use member "Endpoint" of the session as parameter of m_reverseConnectManager.WaitForConnection. * Update SessionReconnectHandler.cs
Bumps [NUnit.Console](https://github.com/nunit/nunit-console) from 3.19.1 to 3.19.2. - [Release notes](https://github.com/nunit/nunit-console/releases) - [Changelog](https://github.com/nunit/nunit-console/blob/main/CHANGES.txt) - [Commits](nunit/nunit-console@3.19.1...3.19.2) --- updated-dependencies: - dependency-name: NUnit.Console dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* enable nrts for CertificatIdentifier&CertificateStoreIdentifier&CertificateTrustList * make RSA Utils and Certificate Stores nullable * Make Certificate validator nullable * fix nullability of CertificateTypeParameter
* Work In Progress * Working Implementation of SupportsFilteredRetain * Potential solution Contains test debug messages that should be cleaned up * Update comments showing discussion required * Address Comments * Use the NodeId from the ConditionState for the ConditionId. Existing case was not guaranteed to be correct.
Set NoDelay=true to disable the Nagle algorithm and set Lingerstate to 5 seconds by default. After careful evaluation of the PR provided by @sxleixer in #2882 we found that the default setting of the socket with NoDelay=false can not only cause issues on the client side, but also on the server side. Due to the nature of Nagle's implementation the issue only occurs when many small service requests or responses are sent over the network. In that case, when packets are still in flight, the secondary small packets are delayed and combined until the MTU is exceeded or the previous packages are acknoledged. The expectation in the UA protocol is to not add additional latency in the client-server communication. As a conclusion defaulting to NoDelay=true appears to be the better default option which works for all use cases. If there are new bandwidth issues related to more and larger packets imposed by this change, they should be solved at the UA application level by combining service requests of the same type. Setting Lingerstate to 5 seconds should help to finish communications when sockets are closed. Co-authored-by: @sxleixer <[email protected]>
…eferenceAssemblies (#3002) Bumps [System.Diagnostics.DiagnosticSource](https://github.com/dotnet/runtime) and [Microsoft.NETFramework.ReferenceAssemblies](https://github.com/Microsoft/dotnet). These dependencies needed to be updated together. Updates `System.Diagnostics.DiagnosticSource` from 6.0.2 to 9.0.2 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.2...v9.0.2) Updates `Microsoft.NETFramework.ReferenceAssemblies` from 1.0.3 to 1.0.3 - [Commits](https://github.com/Microsoft/dotnet/commits) --- updated-dependencies: - dependency-name: System.Diagnostics.DiagnosticSource dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.NETFramework.ReferenceAssemblies dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
|
…e secure channel (#3005)
mregen
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge latest master into release/1.5.375
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...