-
Notifications
You must be signed in to change notification settings - Fork 1k
Explicit ApplicationUri validation on Startup after certificates are loaded & on Client Side CreateSession #3244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
292bc1a
Added RejectCertificateUriMismatch property and explicit ApplicationU…
mrsuciu 3ca4c07
Perform duplicate detection on thumbprint only
mrsuciu 4154c62
Ported handle multiple ApplictionUri, removed assign ApplictionUri fr…
mrsuciu 5c7d74a
Missing letter
mrsuciu 49c833d
Merge branch 'master' into Issue3233
mrsuciu 2476851
Merge branch 'master' into Issue3233
mrsuciu bfacdc3
Fixed LoadPrivateKeyAsync when no applicationUri is passed.
mrsuciu c1387a9
Add tests for validating certificates with multiple AplicationUris on…
mrsuciu 0c395c0
Renamed into CheckOrCreateCertificateAsync, logged Certificate, impro…
mrsuciu 0a17f03
Added retry logic for transient connect errors in CreateSessionApplic…
mrsuciu 69fa6bd
Added TODO log when telemetry instance available
mrsuciu 7c6ad50
Removed unused ValidateServerCertificateApplicationUri(X509Certificat…
mrsuciu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.