Skip to content

[Server] Improve Request Queue, fix Event handling, add Tests#3611

Open
romanett wants to merge 19 commits intomasterfrom
romanett/EventFixes
Open

[Server] Improve Request Queue, fix Event handling, add Tests#3611
romanett wants to merge 19 commits intomasterfrom
romanett/EventFixes

Conversation

@romanett
Copy link
Contributor

@romanett romanett commented Mar 12, 2026

Proposed changes

  • implement RequestQueue using Channels
  • add event load test
  • add event integration test verifying event from server object is received
  • fix Client Reconnect Test
  • fix DiagnosticsNodeManager not creating RootNotifier for Server object
  • add Benchmarks for MonitoredItem.QueueEvent
  • add serveral UnitTest for DiagnosticsNodeManager

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ romanett
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@romanett romanett changed the title Romanett/event fixes [Server] Improve Request Queue, fix Event handling, add Tests Mar 19, 2026
@romanett romanett marked this pull request as ready for review March 19, 2026 06:21
@romanett romanett requested a review from marcschier March 19, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants