fix(SubscriptionManager): replace List with ConcurrentDictionary for abandoned subscriptions (#3617)#3618
Open
cristipogacean wants to merge 2 commits intomasterfrom
Open
fix(SubscriptionManager): replace List with ConcurrentDictionary for abandoned subscriptions (#3617)#3618cristipogacean wants to merge 2 commits intomasterfrom
cristipogacean wants to merge 2 commits intomasterfrom
Conversation
…abandoned subscriptions (#3612) * replace the semaphore-protected `List<ISubscription>` used for abandoned subscriptions with a `readonly ConcurrentDictionary<uint, ISubscription>`, eliminating three separate lock acquisitions in `SessionClosed`, `DeleteSubscription`, and the publish loop * add `DeleteAbandonedSubscriptionsConcurrentlyAsync` integration test to cover the concurrent-delete scenario.
romanett
approved these changes
Mar 14, 2026
Collaborator
|
This needs my fix on the other PR to update the agent image to Windows-2025-vs2026, since msbuild 1.8 is now not found as first in the old image path. Once mine is in, I will take care of resolving merge conflicts and bring this one in. (@romanett @cristipogacean ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
List<ISubscription>used for abandoned subscriptions with areadonly ConcurrentDictionary<uint, ISubscription>, eliminating three separate lock acquisitions inSessionClosed,DeleteSubscription, and the publish loopDeleteAbandonedSubscriptionsConcurrentlyAsyncintegration test to cover the concurrent-delete scenario.Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...