Skip to content

fix(SubscriptionManager): replace List with ConcurrentDictionary for abandoned subscriptions (#3617)#3618

Open
cristipogacean wants to merge 2 commits intomasterfrom
crpogace/fix3612
Open

fix(SubscriptionManager): replace List with ConcurrentDictionary for abandoned subscriptions (#3617)#3618
cristipogacean wants to merge 2 commits intomasterfrom
crpogace/fix3612

Conversation

@cristipogacean
Copy link
Contributor

@cristipogacean cristipogacean commented Mar 13, 2026

Proposed changes

  • replace the semaphore-protected List<ISubscription> used for abandoned subscriptions with a readonly ConcurrentDictionary<uint, ISubscription>, eliminating three separate lock acquisitions in SessionClosed, DeleteSubscription, and the publish loop
  • add DeleteAbandonedSubscriptionsConcurrentlyAsync integration test to cover the concurrent-delete scenario.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

…abandoned subscriptions (#3612)

* replace the semaphore-protected `List<ISubscription>` used for abandoned subscriptions with a `readonly ConcurrentDictionary<uint, ISubscription>`, eliminating three separate lock acquisitions in `SessionClosed`, `DeleteSubscription`, and the publish loop
* add `DeleteAbandonedSubscriptionsConcurrentlyAsync` integration test to cover the concurrent-delete scenario.
@CLAassistant
Copy link

CLAassistant commented Mar 13, 2026

CLA assistant check
All committers have signed the CLA.

@cristipogacean cristipogacean changed the title fix(SubscriptionManager): replace List with ConcurrentDictionary for abandoned subscriptions (#3612) fix(SubscriptionManager): replace List with ConcurrentDictionary for abandoned subscriptions (#3617) Mar 13, 2026
@marcschier
Copy link
Collaborator

This needs my fix on the other PR to update the agent image to Windows-2025-vs2026, since msbuild 1.8 is now not found as first in the old image path. Once mine is in, I will take care of resolving merge conflicts and bring this one in. (@romanett @cristipogacean )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Server] crash during subscription/session teardown in a multi-session telemetry scenario

4 participants