feat: task done #40
Merged
feat: task done #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dheerajyadav1
merged commit aa97624
into
OPCODE-Open-Spring-Fest:main
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors
transform(df)function inapp/etl/transform.pyinto smaller, composable helper functions (_remove_duplicates,_handle_nulls,_standardize_dates,_validate_types).The main
transformfunction now acts as an orchestrator, calling these helpers in sequence.This change directly addresses the request in issue #37 to improve maintainability, code readability, and test granularity. A new test file,
tests/test_transform_helpers.py, has been added to provide specific unit tests for each new helper function.Semver Changes
Issues
Closes #37
Checklist