-
Notifications
You must be signed in to change notification settings - Fork 7
Feat/fresh bollinger bands factor #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ayushkrtiwari
merged 27 commits into
OPCODE-Open-Spring-Fest:main
from
Satvik-Singh192:feat/fresh-bollinger-bands-factor
Oct 23, 2025
Merged
Feat/fresh bollinger bands factor #7
ayushkrtiwari
merged 27 commits into
OPCODE-Open-Spring-Fest:main
from
Satvik-Singh192:feat/fresh-bollinger-bands-factor
Oct 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rules and regulations explained on ai usage
Implements BollingerBandsFactor to compute z-score of price vs rolling mean and std. Includes tests and integration into factors module. Closes OPCODE-Open-Spring-Fest#3
Implements BollingerBandsFactor to compute z-score of price vs rolling mean and std. Includes tests and integration into factors module. Closes OPCODE-Open-Spring-Fest#3
Testing section added to pull request template.
team name typo updated
.github/PULL_REQUEST_TEMPLATE/pr.md
Outdated
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clear this update
…m/Satvik-Singh192/QuantResearch_Opcode into feat/fresh-bollinger-bands-factor
no changes added
original code intact
duplicate file removed
sample prices to be locally generated
ayushkrtiwari
approved these changes
Oct 23, 2025
Collaborator
ayushkrtiwari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
imports arranged according to commitlint.md
file imports arranged
fix lint spacing
Lint issue fixed
lint issue fixed
text sanity
…m/Satvik-Singh192/QuantResearch_Opcode into feat/fresh-bollinger-bands-factor
19c1cd9
into
OPCODE-Open-Spring-Fest:main
6 of 8 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Semver Changes
Issues
Checklist
BollingerBandsFactorinsrc/quant_research_starter/factors/bollinger.py.src/quant_research_starter/factors/__init__.py.tests/test_factors.py.pytestpasses and coverage is unchanged or improved.