Skip to content

feat: enhance shape handling to include image dimensions in canvas #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
+9 −1
Merged

feat: enhance shape handling to include image dimensions in canvas #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion client/src/components/Canvas.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,12 +842,20 @@ if ((Object.values(SHAPE_TYPE).includes(activeTool) || activeTool.startsWith('br
}

// For rectangle/line: set start/end
if (sh.type === SHAPE_TYPE.RECTANGLE || sh.type === SHAPE_TYPE.LINE) {
if (
sh.type === SHAPE_TYPE.RECTANGLE ||
sh.type === SHAPE_TYPE.LINE ||
sh.type === SHAPE_TYPE.IMAGE
) {
// Normalize start/end so start is top-left and end is bottom-right for storage simplicity
const newStart = { x: Math.min(minX, maxX), y: Math.min(minY, maxY) };
const newEnd = { x: Math.max(minX, maxX), y: Math.max(minY, maxY) };
sh.start = newStart;
sh.end = newEnd;
if (sh.type === SHAPE_TYPE.IMAGE) {
sh.width = newEnd.x - newStart.x;
sh.height = newEnd.y - newStart.y;
}
}

// For pen: scale all points from origBBox to new bbox
Expand Down
Loading