Python one-phase (water) simulator #6482
Conversation
totto82
added
the
manual:new-feature
|
jenkins build this please |
| @@ -0,0 +1,53 @@ | |||
| /* | |||
| Copyright 2020 Equinor ASA. | |||
| getPropValue<TypeTag, Properties::EnableBrine>(), | ||
| /*PVOffset=*/0, | ||
| /*enabledCompIdx=*/FluidSystem::waterCompIdx, | ||
| getPropValue<TypeTag, Properties::EnableMICP>()>; |
There was a problem hiding this comment.
Since this was merged #6462, then EnableBioeffects instead of EnableMICP.
| export_PyOnePhaseSimulator(m); | ||
| } | ||
|
|
||
| } // namespace Opm::Pybind No newline at end of file |
|
While this is most welcome, please stabilize previous work first, ref https://ci.opm-project.org/job/opm-nightly-pypi/1713/console |
I'm a bit puzzled because on my local Ctest of test_fluidstate_variables.py, it passes with the reference value in current master. And it passed Jenkins in PR #6075 as well? I can of course update the reference values to the ones given in the opm-nightly-pypi output. My local Ctest fails if I do that, but perhaps Jenkins and opm-nightly-pypi will be happy? Is this some kind of MPI-related issue? Sorry, I'm a bit confused and would like to understand the issue, to not get similar errors again : P |
|
It's passing on some python versions, and not on others, probably related to numpy version. You will have to find something that works everywhere. |
|
Ok, I put up a fix in new PR: #6488. Still unsure if it will pass all tests, crossing my fingers. I will update this PR after the fix has been merged. |
|
I'll check soon, in the middle of something right now. For reference, it's all done using https://github.com/OPM/opm-simulators/tree/master/python/docker and https://github.com/OPM/opm-simulators/tree/master/python/docker/test_wheels/scripts |
svenn-t
force-pushed
the
pysinglephase
branch
from
c383656 to
46559c5
Compare
|
jenkins build this please |
akva2
left a comment
akva2
left a comment
There was a problem hiding this comment.
Green on jenkins, I tested wheels, comments addressed, looks fine to me. In she goes.
4 participants
Added Python one-phase (water) simulator in the same way as the Python gas-water simulator in PR #6075. A Python one-phase simulator can be useful in many applications, especially coupling to external geochemistry and geomechanics solvers.