Testing Module and Phase Transitions#169
Open
aidanfitz wants to merge 39 commits intoORNL-CEES:masterfrom
Open
Testing Module and Phase Transitions#169aidanfitz wants to merge 39 commits intoORNL-CEES:masterfrom
aidanfitz wants to merge 39 commits intoORNL-CEES:masterfrom
Conversation
parikshitbajpai
requested changes
Jun 10, 2025
Comment on lines
+61
to
+69
| subroutine printMolFractions | ||
| USE ModuleThermo | ||
| integer :: i | ||
|
|
||
| do i = 1, nSpecies | ||
| print *, i, cSpeciesName(i), dMolFraction(i) | ||
| end do | ||
|
|
||
| end subroutine printMolFractions |
Collaborator
There was a problem hiding this comment.
This should be part of the output module
src/module/ModuleTesting.f90
Outdated
|
|
||
| contains | ||
|
|
||
| subroutine testMolFraction(dGibbsCheck, dHeatCapacityCheck, nSpeciesTest, iSpeciesIndexTest, dMolFractionTest, lPass) |
Collaborator
There was a problem hiding this comment.
Suggested change
| subroutine testMolFraction(dGibbsCheck, dHeatCapacityCheck, nSpeciesTest, iSpeciesIndexTest, dMolFractionTest, lPass) | |
| subroutine testProperties(dGibbsCheck, dHeatCapacityCheck, nSpeciesTest, iSpeciesIndexTest, dMolFractionTest, lPass) | |
src/module/ModuleTesting.f90
Outdated
|
|
||
| lPass = .TRUE. | ||
|
|
||
| end subroutine testMolFraction |
Collaborator
There was a problem hiding this comment.
Suggested change
| end subroutine testMolFraction | |
| end subroutine testProperties | |
src/postprocess/PhaseTransition.f90
Outdated
| ! | ||
| ! Purpose: | ||
| ! ======== | ||
| !> \details Using a bisection search, this subroutine will find and record temperatures of which a phase has |
Collaborator
There was a problem hiding this comment.
Suggested change
| !> \details Using a bisection search, this subroutine will find and record temperatures of which a phase has | |
| !> \details Using a bisection search, this subroutine will find and record phase transition temperatures. |
|
|
||
|
|
||
|
|
||
| end subroutine PhaseTransition |
Collaborator
There was a problem hiding this comment.
This bisection algorith does appear to work.
Collaborator
|
The makefile is good. Failing validation test needs fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.