Skip to content

Conversation

@colemanjs
Copy link
Collaborator

No description provided.

@colemanjs colemanjs requested a review from gknapp1 September 29, 2025 15:22
@colemanjs colemanjs self-assigned this Sep 29, 2025
@colemanjs
Copy link
Collaborator Author

As well build out applications and utilities, we may want to reconsider where the additivefoam gitInfo header is written for printing additivefoam version information to log files

# Parse arguments for library compilation
. $WM_PROJECT_DIR/wmake/scripts/AllwmakeParseArguments

wmake -all $targetType solvers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same as the following?

cd solvers/additiveFoam
Allwmake

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more generalized form, but the behavior will be the same in the current context. This implementation is taken from (https://github.com/OpenFOAM/OpenFOAM-10/blob/89f925dc708d068f84f51e8317e3bebcda64f5cb/applications/Allwmake#L21), to build any libraries and applications inside of the specified directory tree.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the source script for wmake, which will check for Allwmake scripts in each directory:

https://github.com/OpenFOAM/OpenFOAM-10/blob/89f925dc708d068f84f51e8317e3bebcda64f5cb/wmake/wmake#L302

Copy link
Collaborator

@gknapp1 gknapp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will approve once you clarify the behavior shouldn't change from the current Allwmake script.

@gknapp1 gknapp1 self-requested a review September 29, 2025 20:21
@colemanjs colemanjs marked this pull request as ready for review September 30, 2025 14:59
@colemanjs colemanjs merged commit 99102b7 into main Sep 30, 2025
1 check passed
@colemanjs colemanjs deleted the fixup-Allwmake branch September 30, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants