Merged
Conversation
Replaced FindKLU with FindSuiteSparse, now looking for AMD, COLAMD and KLU libs.
shakedregev
reviewed
Dec 18, 2024
Collaborator
shakedregev
left a comment
There was a problem hiding this comment.
No comments on the code, I ran it successfully.
shakedregev
approved these changes
Dec 18, 2024
Collaborator
|
I just now noticed that |
Collaborator
Author
I can't reproduce this issue and installed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
FindKLU.cmakefile with a more generalFindSuiteSparse.cmake. The new finding function now looks for AMD, COLAMD and KLU libraries. This will be needed for HyKKT integration (currently in works by @shakedregev) as HyKKT links directly to AMD but not KLU. The new finding function can be easily extended to add other libraries from SuiteSparse (I suspect we'll need CHOLMOD soon).Also changed in this PR -- all external dependencies are off by default. User needs to enable them explicitly now.
This PR is mainly reusing @cameronrutherford's work in GridKit.