Change member functions and data names in vector and matrix classes to be more consistent#208
Change member functions and data names in vector and matrix classes to be more consistent#208
Conversation
9c184a1 to
b08a055
Compare
|
Rebased to |
shakedregev
left a comment
There was a problem hiding this comment.
Tests are passing, looks good besides the minor comments
|
I haven't looked at codes changes, but tests are passing for me as well (tested on Frontier). |
kswirydo
left a comment
There was a problem hiding this comment.
My main concern is that now we have copyData[To/From] instead of update but at the same time, we kept setDataUpdated which makes things slightly more confusing.
I am not sure if this makes things more confusing. The purpose of |
Change names of methods and data members in vector and matrix classes to be more consistent and accurate. Specific changes include:
Sparse,Csr,Csc,Coo)setMatrixDatatosetDataPointerssetNewValuestosetValuesPointersupdateDatatocopyDatacopyDatatoconstarrays.owns_*_data_toowns_*_sparsity_pattern_deepCopyVectorDatatocopyDataToupdatetocopyDataFrom.Fixes #167