-
Notifications
You must be signed in to change notification settings - Fork 8
Fix warning on r_KLU_rocsolverrf_asym6x6 #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
shakedregev
approved these changes
Sep 10, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and updating documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were some integer conversion warnings on
r_KLU_rocsolverrf_asym6x6due to the use ofstd::vector, which is indexed differently from Re::Solve storage.Proposed changes
Use
static_castto ensure the proper integer types are used to indexstd::vectorand to instantiate Re::Solve matrices and vectors.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
We could consider avoiding the use of
std::vectorhere altogether. I'm for keeping it, as this is an example, and users should be free to use whatever storage they wish.