Removed all CSC code from CSR solvers. #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakedregev
commented
Sep 10, 2025
shakedregev
added a commit
that referenced
this pull request
Oct 3, 2025
* fix some more memory leaks and add ubsan support to `CMakeLists.txt` (#320) * Fix bug in KLU class affecting non-symmetric linear systems (#323) * Update Spack and setup CI with asan and ubsan variants (#322) * Point Spack to upstream v0.23.1. * Update Frontier modules after Spack upgrade. * Frontier build with +asan+ubsan. * Temporarily point Spack to nkoukpaizan-fork to add asan and ubsan. * +asan+ubsan in GH Actions. * CMake targets for asan and ubsan. * ~asan~ubsan Spack builds on Frontier by default. * Try running CI tests within spack build-env to address the issue of the consumer test not finding the appropriate compiler. * Alias for spack environment in CI. * Revert "Alias for spack environment in CI." This reverts commit fd263ae. * Using `${OLDPWD}` to identify Spack environment. * Add warnings flags to CMake configuration. (#325) --------- Co-authored-by: pelesh <[email protected]> * fix the means by which cmake finds the suitesparse include dir (#327) * Fixed GLU to work on non-symmetric matrices. Co-authored-by: shakedregev <[email protected]> * Synchronize devices after HIP functions (#336) * synchronize devices after HIP functions * Apply pre-commmit fixes * Update resolve/matrix/MatrixHandlerHip.cpp * fixed CUDA * fixed CUDA * Apply pre-commmit fixes * Update resolve/matrix/MatrixHandlerCuda.cpp * Revert "Update resolve/matrix/MatrixHandlerCuda.cpp" This reverts commit 30e41bb. * Revert "Apply pre-commmit fixes" This reverts commit 0bcd8f7. * Revert "fixed CUDA" This reverts commit 62623fa. * Revert "fixed CUDA" This reverts commit b9b249b. --------- Co-authored-by: Shaked Regev <[email protected]@gmail.com> Co-authored-by: shakedregev <[email protected]> * Added the ability to reset a workspace without completely destroying it. (#343) * added method to reset workspace * changed tests * added reset workspace to CUDA * now with comments * Apply pre-commmit fixes * Update resolve/workspace/LinAlgWorkspaceCpu.cpp --------- Co-authored-by: Shaked Regev <[email protected]@gmail.com> Co-authored-by: shakedregev <[email protected]> * Enforce F being 0 and remove duplicate extract factors code * added check for F!=0 * enforce F being 0 and clean up factor extraction code duplication * Apply pre-commmit fixes * Update resolve/LinSolverDirectKLU.cpp * cleaned up comments * Apply pre-commmit fixes * Update resolve/LinSolverDirectKLU.cpp --------- Co-authored-by: shakedregev <[email protected]> * Properly address CSR and CSC discrepancies across all solvers. Fixed discrepancies with minimal overhead. --------- Co-authored-by: shakedregev <[email protected]> Co-authored-by: pelesh <[email protected]> * Put sorting within KLU instead of within other solver logic. (#359) * Adding asymmetric tests (from the data folder) for KLU, CuSolver, and RocSolver. (#364) * tests that are supposed to pass are passing * fixed typos, removed unnecessary file * Apply pre-commmit fixes * renamed matrix files (not added before accidentally) * removed commented out code * fixed failing tests * Apply pre-commmit fixes * fixed commented out code * straggling comment * Update tests/functionality/CMakeLists.txt * Update tests/functionality/CMakeLists.txt * Update tests/functionality/CMakeLists.txt * fixed data path for lusol * consumer * fixed typo * changing to sys refactor, which requires a path * Fix for resolve_consumer to take in the matrices and right hand sides (#365) * Passing matrices and rhs to resolve_consumer. * Minor typo cuda-->hip * adding generic test matrices * modified numbering to suffix * tests failing with well conditioned matrix * updating to better conditioned matrices * SPD test passes consistently, others don't * still testing * changed matrices * updated matrices * changed test mats * changed matrices * symmetric test passing, asymmetric passing when run separately, but not through make test * changed matrices * changed tolerance to machine precision, tests pass! * Apply pre-commmit fixes * updated consumer * fixed non IR related comments * removed IR check, it passes with IR with the better scaled matrices * Apply pre-commmit fixes * Update tests/functionality/CMakeLists.txt * tests passing * Apply pre-commmit fixes * fixed prints * set convergence conditions * setting convergence condition, but it's overridden * set default to relative residual * added default conv_cond * Apply pre-commmit fixes * Update examples/resolve_consumer/CMakeLists.txt * addressed comment * reverted change that made CI test not pass * made matrices consistent, tolerance too stringent * tests passing, renamed files to be consistent * addressed all comments, only tested on Frontier * addressed comments * removed straggling print --------- Co-authored-by: shakedregev <[email protected]> Co-authored-by: Nicholson Koukpaizan <[email protected]> * Shaked/rework examples csr (#367) * fixed examples * kalmarek example * moved to experimental, kalmarek example works * removed commented code * Apply pre-commmit fixes * Update examples/experimental/CMakeLists.txt * addressed change requests * changed cmake --------- Co-authored-by: shakedregev <[email protected]> * Fixed experimental examples to use CSR only. * removed unnecessary Csc reference from examples * removed build files * fixed segfault * fixed glu update * fixed all experimental examples * somehow this segmentation fault fix didn't save * fixed fgmres * Apply pre-commmit fixes * Update examples/experimental/r_KLU_cusolverrf_redo_factorization.cpp * Update examples/experimental/r_KLU_cusolverrf_redo_factorization.cpp * Update examples/experimental/r_KLU_cusolverrf_redo_factorization.cpp --------- Co-authored-by: shakedregev <[email protected]> * Fix warning on r_KLU_rocsolverrf_asym6x6 * Fix warning on r_KLU_rocsolverrf_asym6x6. --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Shaked Regev <[email protected]> * Removed all CSC code from CSR solvers. (#375) * removed all CSC code * Apply pre-commmit fixes * Update tests/functionality/testRefactor.cpp --------- Co-authored-by: shakedregev <[email protected]> * Removed rocSparse "fast" solver from our options (#377) Removed all "fast" solver code. --------- Co-authored-by: shakedregev <[email protected]> * Updated changelog and PR template (#381) * Update emails in README.md * Add code of conduct. * Move code of conduct. * Add badges * Change action name to CPU Tests * Update README.md * Add logo to the README file. * Add logo to readthedocs. * Manage images for light/dark schemes in README. * Add logo to Doxygen docs. * Fix path to logo in Doxygen. * Update logos * Add svg logo images. * Update README.md * Update doxygen landing page. * Monor changes to Doxygen landing page * Updated coding and developer guidelines (#242) Added details about implicit coding guidelines that were not specified. Added suggested branching workflow. Added PR reviewing and opening and issue guidelines. Fixed typos Restructured documentation sections Co-authored-by: pelesh <[email protected]> * Update readthedocs links in README.md Updated links in README to pint to readthedocs pages generated from `frontmatter-dev` branch. This needs to be reverted before merging. * documentation clarification (#267) * fixing typos * fixed typos * Restructured documentation files (#299) --------- Co-authored-by: Adham Ibrahim <[email protected]> Co-authored-by: Slaven Peles <[email protected]> * Apply pre-commmit fixes * Use Re::Solve instead of ReSolve and update Doxygen logo. * Simplify doxygen stylesheet, allow dark mode * [skip ci] Revert sidebar-only mode. * [skip ci] Another shot on sidebar only doxy theme * ReSolve -> Re::Solve * Apply pre-commmit fixes * Copy Doxyfile.in -> Doxyfile and then modify. * updated contributors * straggling changes * Use correct Doxyfile * Undo doxyfile template changes * rebased frontmatter-dev --------- Co-authored-by: superwhiskers <[email protected]> Co-authored-by: Nicholson Koukpaizan <[email protected]> Co-authored-by: pelesh <[email protected]> Co-authored-by: shakedregev <[email protected]> Co-authored-by: Shaked Regev <[email protected]@gmail.com> Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Adham Ibrahim <[email protected]> Co-authored-by: pelesh <[email protected]>
shakedregev
added a commit
that referenced
this pull request
Oct 3, 2025
* fix some more memory leaks and add ubsan support to `CMakeLists.txt` (#320) * Fix bug in KLU class affecting non-symmetric linear systems (#323) * Update Spack and setup CI with asan and ubsan variants (#322) * Point Spack to upstream v0.23.1. * Update Frontier modules after Spack upgrade. * Frontier build with +asan+ubsan. * Temporarily point Spack to nkoukpaizan-fork to add asan and ubsan. * +asan+ubsan in GH Actions. * CMake targets for asan and ubsan. * ~asan~ubsan Spack builds on Frontier by default. * Try running CI tests within spack build-env to address the issue of the consumer test not finding the appropriate compiler. * Alias for spack environment in CI. * Revert "Alias for spack environment in CI." This reverts commit fd263ae. * Using `${OLDPWD}` to identify Spack environment. * Add warnings flags to CMake configuration. (#325) --------- Co-authored-by: pelesh <[email protected]> * fix the means by which cmake finds the suitesparse include dir (#327) * Fixed GLU to work on non-symmetric matrices. Co-authored-by: shakedregev <[email protected]> * Synchronize devices after HIP functions (#336) * synchronize devices after HIP functions * Apply pre-commmit fixes * Update resolve/matrix/MatrixHandlerHip.cpp * fixed CUDA * fixed CUDA * Apply pre-commmit fixes * Update resolve/matrix/MatrixHandlerCuda.cpp * Revert "Update resolve/matrix/MatrixHandlerCuda.cpp" This reverts commit 30e41bb. * Revert "Apply pre-commmit fixes" This reverts commit 0bcd8f7. * Revert "fixed CUDA" This reverts commit 62623fa. * Revert "fixed CUDA" This reverts commit b9b249b. --------- Co-authored-by: Shaked Regev <[email protected]@gmail.com> Co-authored-by: shakedregev <[email protected]> * Added the ability to reset a workspace without completely destroying it. (#343) * added method to reset workspace * changed tests * added reset workspace to CUDA * now with comments * Apply pre-commmit fixes * Update resolve/workspace/LinAlgWorkspaceCpu.cpp --------- Co-authored-by: Shaked Regev <[email protected]@gmail.com> Co-authored-by: shakedregev <[email protected]> * Enforce F being 0 and remove duplicate extract factors code * added check for F!=0 * enforce F being 0 and clean up factor extraction code duplication * Apply pre-commmit fixes * Update resolve/LinSolverDirectKLU.cpp * cleaned up comments * Apply pre-commmit fixes * Update resolve/LinSolverDirectKLU.cpp --------- Co-authored-by: shakedregev <[email protected]> * Properly address CSR and CSC discrepancies across all solvers. Fixed discrepancies with minimal overhead. --------- Co-authored-by: shakedregev <[email protected]> Co-authored-by: pelesh <[email protected]> * Put sorting within KLU instead of within other solver logic. (#359) * Adding asymmetric tests (from the data folder) for KLU, CuSolver, and RocSolver. (#364) * tests that are supposed to pass are passing * fixed typos, removed unnecessary file * Apply pre-commmit fixes * renamed matrix files (not added before accidentally) * removed commented out code * fixed failing tests * Apply pre-commmit fixes * fixed commented out code * straggling comment * Update tests/functionality/CMakeLists.txt * Update tests/functionality/CMakeLists.txt * Update tests/functionality/CMakeLists.txt * fixed data path for lusol * consumer * fixed typo * changing to sys refactor, which requires a path * Fix for resolve_consumer to take in the matrices and right hand sides (#365) * Passing matrices and rhs to resolve_consumer. * Minor typo cuda-->hip * adding generic test matrices * modified numbering to suffix * tests failing with well conditioned matrix * updating to better conditioned matrices * SPD test passes consistently, others don't * still testing * changed matrices * updated matrices * changed test mats * changed matrices * symmetric test passing, asymmetric passing when run separately, but not through make test * changed matrices * changed tolerance to machine precision, tests pass! * Apply pre-commmit fixes * updated consumer * fixed non IR related comments * removed IR check, it passes with IR with the better scaled matrices * Apply pre-commmit fixes * Update tests/functionality/CMakeLists.txt * tests passing * Apply pre-commmit fixes * fixed prints * set convergence conditions * setting convergence condition, but it's overridden * set default to relative residual * added default conv_cond * Apply pre-commmit fixes * Update examples/resolve_consumer/CMakeLists.txt * addressed comment * reverted change that made CI test not pass * made matrices consistent, tolerance too stringent * tests passing, renamed files to be consistent * addressed all comments, only tested on Frontier * addressed comments * removed straggling print --------- Co-authored-by: shakedregev <[email protected]> Co-authored-by: Nicholson Koukpaizan <[email protected]> * Shaked/rework examples csr (#367) * fixed examples * kalmarek example * moved to experimental, kalmarek example works * removed commented code * Apply pre-commmit fixes * Update examples/experimental/CMakeLists.txt * addressed change requests * changed cmake --------- Co-authored-by: shakedregev <[email protected]> * Fixed experimental examples to use CSR only. * removed unnecessary Csc reference from examples * removed build files * fixed segfault * fixed glu update * fixed all experimental examples * somehow this segmentation fault fix didn't save * fixed fgmres * Apply pre-commmit fixes * Update examples/experimental/r_KLU_cusolverrf_redo_factorization.cpp * Update examples/experimental/r_KLU_cusolverrf_redo_factorization.cpp * Update examples/experimental/r_KLU_cusolverrf_redo_factorization.cpp --------- Co-authored-by: shakedregev <[email protected]> * Fix warning on r_KLU_rocsolverrf_asym6x6 * Fix warning on r_KLU_rocsolverrf_asym6x6. --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Shaked Regev <[email protected]> * Removed all CSC code from CSR solvers. (#375) * removed all CSC code * Apply pre-commmit fixes * Update tests/functionality/testRefactor.cpp --------- Co-authored-by: shakedregev <[email protected]> * Removed rocSparse "fast" solver from our options (#377) Removed all "fast" solver code. --------- Co-authored-by: shakedregev <[email protected]> * Updated changelog and PR template (#381) * Update emails in README.md * Add code of conduct. * Move code of conduct. * Add badges * Change action name to CPU Tests * Update README.md * Add logo to the README file. * Add logo to readthedocs. * Manage images for light/dark schemes in README. * Add logo to Doxygen docs. * Fix path to logo in Doxygen. * Update logos * Add svg logo images. * Update README.md * Update doxygen landing page. * Monor changes to Doxygen landing page * Updated coding and developer guidelines (#242) Added details about implicit coding guidelines that were not specified. Added suggested branching workflow. Added PR reviewing and opening and issue guidelines. Fixed typos Restructured documentation sections Co-authored-by: pelesh <[email protected]> * Update readthedocs links in README.md Updated links in README to pint to readthedocs pages generated from `frontmatter-dev` branch. This needs to be reverted before merging. * documentation clarification (#267) * fixing typos * fixed typos * Restructured documentation files (#299) --------- Co-authored-by: Adham Ibrahim <[email protected]> Co-authored-by: Slaven Peles <[email protected]> * Apply pre-commmit fixes * Use Re::Solve instead of ReSolve and update Doxygen logo. * Simplify doxygen stylesheet, allow dark mode * [skip ci] Revert sidebar-only mode. * [skip ci] Another shot on sidebar only doxy theme * ReSolve -> Re::Solve * Apply pre-commmit fixes * Copy Doxyfile.in -> Doxyfile and then modify. * updated contributors * straggling changes * Use correct Doxyfile * Undo doxyfile template changes * rebased frontmatter-dev --------- Co-authored-by: superwhiskers <[email protected]> Co-authored-by: Nicholson Koukpaizan <[email protected]> Co-authored-by: pelesh <[email protected]> Co-authored-by: shakedregev <[email protected]> Co-authored-by: Shaked Regev <[email protected]@gmail.com> Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Adham Ibrahim <[email protected]> Co-authored-by: pelesh <[email protected]>
pelesh
added a commit
that referenced
this pull request
Oct 7, 2025
* fix some more memory leaks and add ubsan support to `CMakeLists.txt` (#320) * Fix bug in KLU class affecting non-symmetric linear systems (#323) * Update Spack and setup CI with asan and ubsan variants (#322) * Point Spack to upstream v0.23.1. * Update Frontier modules after Spack upgrade. * Frontier build with +asan+ubsan. * Temporarily point Spack to nkoukpaizan-fork to add asan and ubsan. * +asan+ubsan in GH Actions. * CMake targets for asan and ubsan. * ~asan~ubsan Spack builds on Frontier by default. * Try running CI tests within spack build-env to address the issue of the consumer test not finding the appropriate compiler. * Alias for spack environment in CI. * Revert "Alias for spack environment in CI." This reverts commit fd263ae. * Using `${OLDPWD}` to identify Spack environment. * Add warnings flags to CMake configuration. (#325) --------- Co-authored-by: pelesh <[email protected]> * fix the means by which cmake finds the suitesparse include dir (#327) * Fixed GLU to work on non-symmetric matrices. Co-authored-by: shakedregev <[email protected]> * Synchronize devices after HIP functions (#336) * synchronize devices after HIP functions * Apply pre-commmit fixes * Update resolve/matrix/MatrixHandlerHip.cpp * fixed CUDA * fixed CUDA * Apply pre-commmit fixes * Update resolve/matrix/MatrixHandlerCuda.cpp * Revert "Update resolve/matrix/MatrixHandlerCuda.cpp" This reverts commit 30e41bb. * Revert "Apply pre-commmit fixes" This reverts commit 0bcd8f7. * Revert "fixed CUDA" This reverts commit 62623fa. * Revert "fixed CUDA" This reverts commit b9b249b. --------- Co-authored-by: Shaked Regev <[email protected]@gmail.com> Co-authored-by: shakedregev <[email protected]> * Added the ability to reset a workspace without completely destroying it. (#343) * added method to reset workspace * changed tests * added reset workspace to CUDA * now with comments * Apply pre-commmit fixes * Update resolve/workspace/LinAlgWorkspaceCpu.cpp --------- Co-authored-by: Shaked Regev <[email protected]@gmail.com> Co-authored-by: shakedregev <[email protected]> * Enforce F being 0 and remove duplicate extract factors code * added check for F!=0 * enforce F being 0 and clean up factor extraction code duplication * Apply pre-commmit fixes * Update resolve/LinSolverDirectKLU.cpp * cleaned up comments * Apply pre-commmit fixes * Update resolve/LinSolverDirectKLU.cpp --------- Co-authored-by: shakedregev <[email protected]> * Properly address CSR and CSC discrepancies across all solvers. Fixed discrepancies with minimal overhead. --------- Co-authored-by: shakedregev <[email protected]> Co-authored-by: pelesh <[email protected]> * Put sorting within KLU instead of within other solver logic. (#359) * Adding asymmetric tests (from the data folder) for KLU, CuSolver, and RocSolver. (#364) * tests that are supposed to pass are passing * fixed typos, removed unnecessary file * Apply pre-commmit fixes * renamed matrix files (not added before accidentally) * removed commented out code * fixed failing tests * Apply pre-commmit fixes * fixed commented out code * straggling comment * Update tests/functionality/CMakeLists.txt * Update tests/functionality/CMakeLists.txt * Update tests/functionality/CMakeLists.txt * fixed data path for lusol * consumer * fixed typo * changing to sys refactor, which requires a path * Fix for resolve_consumer to take in the matrices and right hand sides (#365) * Passing matrices and rhs to resolve_consumer. * Minor typo cuda-->hip * adding generic test matrices * modified numbering to suffix * tests failing with well conditioned matrix * updating to better conditioned matrices * SPD test passes consistently, others don't * still testing * changed matrices * updated matrices * changed test mats * changed matrices * symmetric test passing, asymmetric passing when run separately, but not through make test * changed matrices * changed tolerance to machine precision, tests pass! * Apply pre-commmit fixes * updated consumer * fixed non IR related comments * removed IR check, it passes with IR with the better scaled matrices * Apply pre-commmit fixes * Update tests/functionality/CMakeLists.txt * tests passing * Apply pre-commmit fixes * fixed prints * set convergence conditions * setting convergence condition, but it's overridden * set default to relative residual * added default conv_cond * Apply pre-commmit fixes * Update examples/resolve_consumer/CMakeLists.txt * addressed comment * reverted change that made CI test not pass * made matrices consistent, tolerance too stringent * tests passing, renamed files to be consistent * addressed all comments, only tested on Frontier * addressed comments * removed straggling print --------- Co-authored-by: shakedregev <[email protected]> Co-authored-by: Nicholson Koukpaizan <[email protected]> * Shaked/rework examples csr (#367) * fixed examples * kalmarek example * moved to experimental, kalmarek example works * removed commented code * Apply pre-commmit fixes * Update examples/experimental/CMakeLists.txt * addressed change requests * changed cmake --------- Co-authored-by: shakedregev <[email protected]> * Fixed experimental examples to use CSR only. * removed unnecessary Csc reference from examples * removed build files * fixed segfault * fixed glu update * fixed all experimental examples * somehow this segmentation fault fix didn't save * fixed fgmres * Apply pre-commmit fixes * Update examples/experimental/r_KLU_cusolverrf_redo_factorization.cpp * Update examples/experimental/r_KLU_cusolverrf_redo_factorization.cpp * Update examples/experimental/r_KLU_cusolverrf_redo_factorization.cpp --------- Co-authored-by: shakedregev <[email protected]> * Fix warning on r_KLU_rocsolverrf_asym6x6 * Fix warning on r_KLU_rocsolverrf_asym6x6. --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Shaked Regev <[email protected]> * Removed all CSC code from CSR solvers. (#375) * removed all CSC code * Apply pre-commmit fixes * Update tests/functionality/testRefactor.cpp --------- Co-authored-by: shakedregev <[email protected]> * Removed rocSparse "fast" solver from our options (#377) Removed all "fast" solver code. --------- Co-authored-by: shakedregev <[email protected]> * Updated changelog and PR template (#381) * Update emails in README.md * Add code of conduct. * Move code of conduct. * Add badges * Change action name to CPU Tests * Update README.md * Add logo to the README file. * Add logo to readthedocs. * Manage images for light/dark schemes in README. * Add logo to Doxygen docs. * Fix path to logo in Doxygen. * Update logos * Add svg logo images. * Update README.md * Update doxygen landing page. * Monor changes to Doxygen landing page * Updated coding and developer guidelines (#242) Added details about implicit coding guidelines that were not specified. Added suggested branching workflow. Added PR reviewing and opening and issue guidelines. Fixed typos Restructured documentation sections Co-authored-by: pelesh <[email protected]> * Update readthedocs links in README.md Updated links in README to pint to readthedocs pages generated from `frontmatter-dev` branch. This needs to be reverted before merging. * documentation clarification (#267) * fixing typos * fixed typos * Restructured documentation files (#299) --------- Co-authored-by: Adham Ibrahim <[email protected]> Co-authored-by: Slaven Peles <[email protected]> * Apply pre-commmit fixes * Use Re::Solve instead of ReSolve and update Doxygen logo. * Simplify doxygen stylesheet, allow dark mode * [skip ci] Revert sidebar-only mode. * [skip ci] Another shot on sidebar only doxy theme * ReSolve -> Re::Solve * Apply pre-commmit fixes * Copy Doxyfile.in -> Doxyfile and then modify. * updated contributors * straggling changes * Use correct Doxyfile * Undo doxyfile template changes * rebased frontmatter-dev --------- Co-authored-by: superwhiskers <[email protected]> Co-authored-by: Nicholson Koukpaizan <[email protected]> Co-authored-by: pelesh <[email protected]> Co-authored-by: shakedregev <[email protected]> Co-authored-by: Shaked Regev <[email protected]@gmail.com> Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Adham Ibrahim <[email protected]> Co-authored-by: pelesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed unnecessary functions and renamed everything to CSR by default. This is the last in a string of these PRs.
Closes #363.
Closes #357.
Proposed changes
I removed all CSC assumption code (
combineFactors,getFactor,extractFactor,setup) and renamed the CSR assumption code as the default.Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.