Skip to content

Conversation

@KakeruUeda
Copy link
Collaborator

@KakeruUeda KakeruUeda commented Dec 17, 2025

Description

This adds an example that solves a linear system with GMRES through the SystemSolver interface in ReSolve, demonstrating how to use it in user applications.

Closes #400

Proposed changes

  • Add a new example source file example/sysGmres.cpp.

Note: The HIP backend has not been tested yet, as HIP is not available in my current setup.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • All tests pass. Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • N/A There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

I would appreciate any help with testing this example on the HIP backend.

@KakeruUeda KakeruUeda requested a review from pelesh December 17, 2025 06:19
@KakeruUeda KakeruUeda self-assigned this Dec 17, 2025
@pelesh
Copy link
Collaborator

pelesh commented Dec 17, 2025

Tested on HIP backend and all tests passed. Ran the sysGmres.exe example on a HIP backend and had system converge.

Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog. Otherwise ready to merge.

@KakeruUeda
Copy link
Collaborator Author

Thank you. I've updated the changelog.

@pelesh pelesh merged commit c62a4bc into develop Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create sysGmres example

3 participants