Skip to content

Conversation

@pelesh
Copy link
Collaborator

@pelesh pelesh commented Jan 5, 2026

  • Bug: update MatrixHandler::addConst return type to int

  • Doc: Update CHANGELOG.md

Description

External PR #402 merged to a local branch. Passing through CI pipeline before merging to develop.

Closes #395

@MaanasArora

Proposed changes

Correct the return type for MatrixHandler::addConst.

Checklist

  • All tests pass. Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

* Bug: update MatrixHandler::addConst return type to int

* Doc: Update CHANGELOG.md
@pelesh pelesh added this to the Release 0.99.3 milestone Jan 5, 2026
@pelesh pelesh self-assigned this Jan 5, 2026
@pelesh pelesh added the bug Something isn't working label Jan 5, 2026
@pelesh pelesh merged commit 0c9f685 into develop Jan 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: MatrixHandler::addConst return type doesn't match documentation

4 participants