Use BLAS naming for VectorHandler methods#411
Merged
Conversation
14 tasks
Collaborator
|
Shouldn't the infinity norm be |
Collaborator
Author
Good catch. Addressed in 8310c9f. |
kakeueda
reviewed
Feb 26, 2026
kakeueda
reviewed
Feb 26, 2026
kakeueda
reviewed
Feb 26, 2026
Collaborator
kakeueda
left a comment
There was a problem hiding this comment.
All tests passed with the CUDA backend after fixing VectorHandlerCuda::scal
14 tasks
kakeueda
requested changes
Feb 26, 2026
shakedregev
reviewed
Feb 26, 2026
shakedregev
reviewed
Feb 26, 2026
shakedregev
reviewed
Feb 26, 2026
shakedregev
reviewed
Feb 26, 2026
shakedregev
reviewed
Feb 26, 2026
shakedregev
requested changes
Feb 26, 2026
Collaborator
shakedregev
left a comment
There was a problem hiding this comment.
Fix the failing asserts and name convention violations.
kakeueda
approved these changes
Feb 26, 2026
shakedregev
reviewed
Mar 3, 2026
Collaborator
shakedregev
left a comment
There was a problem hiding this comment.
These are important changes. There are a few naming things that slipped.
shakedregev
approved these changes
Mar 3, 2026
Collaborator
shakedregev
left a comment
There was a problem hiding this comment.
Approved after testing on Cuda and RocM
shakedregev
reviewed
Mar 3, 2026
Remove ambiguity with Oxford comma
typo fix
2a26d63 to
8d6fea5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates names of methods in
VecorHandlerto match BLAS naming convention.Closes #410
CC @alexander-novo
Proposed changes
assertstatements added to aid debugging.Checklist
make testandmake test_installper testing instructions). Code tested on./examples/<your_example>.exe -hto get instructions how to run examples). Code tested on:-Wall -Wpedantic -Wconversion -Wextra.Further comments
Assert statements in
gemvfail for some reason. Need to investigate that more; out of scope here.