Support for MeMo 1.2 #189
Open
Support for MeMo 1.2 #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/5189-memo-1.2
branch
from
ffecec3 to
7533b14
Compare
jekuaitk
approved these changes
Aug 22, 2025
| @@ -98,21 +116,40 @@ public function send( | |||
| throw new InvalidArgumentException(sprintf('Invalid type: %s. Must be one of %s.', $quote($type), implode(', ', array_map($quote, SF1601::TYPES)))); | |||
| } | |||
|
|
|||
| $meMoVersion = $options['memo-version']; | |||
There was a problem hiding this comment.
Should we leave a comment explaining that if no memo-version is provided, 1.2 is the default?
jekuaitk
approved these changes
Aug 22, 2025
martinyde
approved these changes
Aug 26, 2025
stankut
reviewed
Aug 28, 2025
modules/os2forms_digital_post/src/Drush/Commands/DigitalPostTestCommands.php
Show resolved
Hide resolved
rimi-itk
force-pushed
the
feature/5189-memo-1.2
branch
from
dc7fa8a to
62652e1
Compare
This was referenced Sep 1, 2025
stankut
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #170.
Adds support for MeMo 1.2 (https://digitaliser.dk/digital-post/nyhedsarkiv/2025/mar/lancering-af-memo-version-12)
Important
Notice that this pull request is sort of a hotfix release and therefore targets the
masterbranch.