Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4457, fixes #3281, and contributes to #4650. The current PR upgrades datatables, updates references to bootstrap 4 datatables styling, and maintains current behavior.
Due to the
domattribute being deprecated, I did have to adjust some styles, for example placing the info text on the top right of the table, rather than top left below the filter. The checkboxes were also centered in their column.Unfortunately this does not fix the screenreader problem noted in the issue, but being on the latest datatables version gets us closer. The new version also has a few new features, like automatically detecting numeric and date info and formatting/sorting it correctly, which make it an improvement over the previous version.
There is more work to be done resolving the screenreader problem and adding internationalizations to the datatables text, but it seems best to do that work in a separate PR.